Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure package to format_version 3.0.0 #8050

Conversation

tommyers-elastic
Copy link
Contributor

@tommyers-elastic tommyers-elastic commented Oct 2, 2023

This PR updates azure to format_version 3.0.0.

The change consists of the following:

  1. elastic-package format - this is isolated in the first commit and can be excluded to simplify code review.
  2. Removal of duplicate field mappings.
  3. Some messy re-definitions of geo fields at the root level of the package. these need to be removed, but for now we had to add non-external definitions in order to pass the validations.
  4. changes to the manifest in order to comply with the latest package-spec.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@elasticmachine
Copy link

elasticmachine commented Oct 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-13T11:21:15.553+0000

  • Duration: 14 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

…pec v3.

The changes here primarily consist of:

1. Removing duplicate fields
2. Clarifying type of 'array' fields.
3. Moving root-level 'geo' fields out of external ECS definitions.
   This one is a little weird - ECS mandates that 'geo' fields should be nested.
   We get validation errors if we have them as 'external' at root level, but
   we need to keep them for backwards compatibility. So we add their
   definitions into the custom mappings files.
@elasticmachine
Copy link

elasticmachine commented Oct 13, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -10.336
Classes 86.364% (19/22) 👎 -10.336
Methods 83.333% (155/186) 👎 -9.284
Lines 85.021% (2821/3318) 👎 -3.368
Conditionals 100.0% (0/0) 💚

@tommyers-elastic tommyers-elastic marked this pull request as ready for review October 13, 2023 11:27
@tommyers-elastic tommyers-elastic requested a review from a team as a code owner October 13, 2023 11:27
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tommyers-elastic tommyers-elastic merged commit 3e15a1d into elastic:main Oct 16, 2023
4 checks passed
@elasticmachine
Copy link

Package azure - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants