Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[obs-cloud-monitoring] Add undefined log.file.* fields breaking tests for filestream inputs #8068

Merged
merged 4 commits into from Oct 4, 2023

Conversation

bhapas
Copy link
Contributor

@bhapas bhapas commented Oct 3, 2023

What does this PR do?

Issue described in #7687

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@elasticmachine
Copy link

elasticmachine commented Oct 3, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-03T14:29:22.403+0000

  • Duration: 53 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 167
Skipped 0
Total 167

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 3, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (6/6) 💚 11.864
Classes 100.0% (6/6) 💚 11.864
Methods 94.545% (156/165) 👍 2.355
Lines 96.122% (694/722) 👍 9.651
Conditionals 100.0% (0/0) 💚

@bhapas bhapas force-pushed the obs-cloud-filestream-changes branch from 0beddc9 to 5b38627 Compare October 3, 2023 13:33
@bhapas bhapas marked this pull request as ready for review October 3, 2023 18:49
@bhapas bhapas requested a review from a team as a code owner October 3, 2023 18:49
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhapas bhapas self-assigned this Oct 4, 2023
@bhapas bhapas merged commit 2b9b28b into elastic:main Oct 4, 2023
4 checks passed
@bhapas bhapas deleted the obs-cloud-filestream-changes branch October 4, 2023 10:39
@elasticmachine
Copy link

Package docker - 2.9.0 containing this change is available at https://epr.elastic.co/search?package=docker

@elasticmachine
Copy link

Package istio - 0.5.0 containing this change is available at https://epr.elastic.co/search?package=istio

@elasticmachine
Copy link

Package kubernetes - 1.46.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

@elasticmachine
Copy link

Package nginx_ingress_controller - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=nginx_ingress_controller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants