[elastic_agent] - Cleanup fields.yml issues #8079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added a commit
to andrewkroh/integrations
that referenced
this pull request
Oct 3, 2023
[git-generate] cd packages/elastic_agent elastic-package changelog add --link elastic#8079 --type enhancement --next minor --description "Modify field mappings to reference ECS fields where possible and remove duplicate field declarations."
andrewkroh
added
enhancement
andrewkroh
added a commit
to andrewkroh/integrations
that referenced
this pull request
Oct 3, 2023
[git-generate] cd packages/elastic_agent elastic-package changelog add --link elastic#8079 --type enhancement --next minor --description "Modified the field definitions to reference ECS where possible and remove invalid field attributes."
andrewkroh
force-pushed
the
elastic_agent/feature/field-cleanup
branch
from
485c9e1
to
3e22b5c
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
andrewkroh
added a commit
to andrewkroh/integrations
that referenced
this pull request
Oct 4, 2023
[git-generate] cd packages/elastic_agent elastic-package changelog add --link elastic#8079 --type enhancement --next minor --description "Modified the field definitions to reference ECS where possible and remove invalid field attributes."
andrewkroh
force-pushed
the
elastic_agent/feature/field-cleanup
branch
from
3e22b5c
to
c0f8924
Compare
[git-generate] cd packages/elastic_agent go run github.com/andrewkroh/fydler@90f7b627e -fix -a useecs **/fields/*.yml elastic-package format
[git-generate] cd packages/elastic_agent go run github.com/andrewkroh/fydler@90f7b627e -fix -a invalidattribute **/fields/*.yml elastic-package format
[git-generate] cd packages/elastic_agent go run github.com/andrewkroh/fydler@90f7b627e -fix -a unknownattribute **/fields/*.yml elastic-package format
[git-generate] perl -p -i -e 's/descripion:/description:/g' packages/elastic_agent/**/fields/*.yml
Fixes multiple duplicated field declarations. message is declared 2 times message is declared 2 times beat.stats.libbeat.output.events.duplicates is declared 2 times beat.stats.libbeat.output.events.toomany is declared 2 times beat.stats.libbeat.output.write.bytes is declared 2 times beat.stats.libbeat.output.events.dropped is declared 2 times beat.stats.libbeat.output.write.errors is declared 2 times beat.stats.libbeat.output.events.active is declared 2 times beat.stats.libbeat.output.events.batches is declared 2 times beat.stats.libbeat.output.events.total is declared 2 times beat.stats.libbeat.output.events.acked is declared 2 times beat.stats.libbeat.output.events.failed is declared 2 times agent.id is declared 2 times
[git-generate] cd packages/elastic_agent elastic-package changelog add --link elastic#8079 --type enhancement --next minor --description "Modified the field definitions to reference ECS where possible and remove invalid field attributes."
andrewkroh
force-pushed
the
elastic_agent/feature/field-cleanup
branch
from
c0f8924
to
4fb7ba6
Compare
cmacknz
approved these changes
Oct 4, 2023
|
Package elastic_agent - 1.14.0 containing this change is available at https://epr.elastic.co/search?package=elastic_agent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This fixes most of the issues necessary to upgrade this package to
format_version: 3.0.0and does some general housekeeping.For fields that exist in ECS use 'external: ecs' in the field definition.
Remove attributes from field definitions that have no purpose (like footnote, level, title, etc).
Fix typo for description attribute in some field definitions.
Remove duplicate definitions of fields within the same data stream.
Fix dotted YAML key in manifest.yml.
Checklist
changelog.ymlfile.