Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zookeeper] Added dimensions mapping to server datastream #8081

Merged
merged 3 commits into from Oct 11, 2023

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Oct 4, 2023

  • Enhancement

What does this PR do?

Added dimension mapping for server datastream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

  • elastic-package build
  • Mapping tests completed
  • Dashboard tests completed

Related issues

Screenshots

image

@agithomas agithomas changed the title [Zookeeper] Added dimensions mapping to zookeeper server datastream [Zookeeper] Added dimensions mapping to server datastream Oct 4, 2023
@elasticmachine
Copy link

elasticmachine commented Oct 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-11T13:26:00.731+0000

  • Duration: 15 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 4, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 66.667% (6/9) 👍 38.889
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@agithomas
Copy link
Contributor Author

Settings verification
      "hidden": "true",
      "time_series": {
        "end_time": "2023-10-04T14:47:17.000Z",
        "start_time": "2023-10-04T04:20:16.000Z"
      },
Mapping check
             "mode": {
                "type": "keyword",
                "time_series_dimension": true
              },
              "node_count": {
                "type": "long",
                "time_series_metric": "gauge"
              },
              "outstanding": {
                "type": "long",
                "time_series_metric": "gauge"
              },
              "received": {
                "type": "long",
                "time_series_metric": "counter"
              },
              "sent": {
                "type": "long",
                "time_series_metric": "counter"
              },
              "version_date": {
                "type": "date"
              },
              "zxid": {
                "type": "keyword",
                "time_series_dimension": true
              }
Rollover Testing
GET _index_template/metrics-zookeeper.server

PUT _index_template/metrics-zookeeper.server
{
      "index_patterns": [
        "metrics-zookeeper.server-*"
      ],
      "template": {
        "settings": {
          "index": {
            "mode": null
          }
        }
    },
    "composed_of": [
          "metrics-zookeeper.server@package",
          "metrics-zookeeper.server@custom",
          ".fleet_globals-1",
          ".fleet_agent_id_verification-1"
    ],
    "priority": 200,
    "data_stream": {
      "hidden": false,
      "allow_custom_routing": false
    }
}

POST metrics-zookeeper.server-default/_rollover
{
  "acknowledged": true,
  "shards_acknowledged": true,
  "old_index": ".ds-metrics-zookeeper.server-default-2023.10.04-000003",
  "new_index": ".ds-metrics-zookeeper.server-default-2023.10.04-000004",
  "rolled_over": true,
  "dry_run": false,
  "conditions": {}
}

@agithomas agithomas marked this pull request as ready for review October 4, 2023 12:49
@agithomas agithomas requested a review from a team as a code owner October 4, 2023 12:49
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas mentioned this pull request Oct 11, 2023
11 tasks
@agithomas agithomas merged commit 701558e into elastic:main Oct 11, 2023
4 checks passed
@elasticmachine
Copy link

Package zookeeper - 1.8.5 containing this change is available at https://epr.elastic.co/search?package=zookeeper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants