Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoblox_bloxone_ddi: fix handling of options fields #8082

Merged
merged 1 commit into from Oct 12, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Oct 4, 2023

Proposed commit message

We have a report of the options field of the dhcp_lease dataset coming in as a string rather than an object, so conditionally on type, apply a JSON parse processor. There is also an options field in the dns_data datastream, so defensively also apply the change there, though note #7924 (comment).

/cc @MakoWish

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working Team:Security-External Integrations Integration:infoblox_bloxone_ddi Infoblox BloxOne DDI (DNS, DHCP, IP management) labels Oct 4, 2023
@efd6 efd6 self-assigned this Oct 4, 2023
@efd6 efd6 force-pushed the 7924-infoblox_bloxone_ddi branch from 63c4bc6 to 2bb32f3 Compare October 4, 2023 06:36
@elasticmachine
Copy link

elasticmachine commented Oct 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-04T19:57:08.835+0000

  • Duration: 17 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 4, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 100.0% (42/42) 💚 12.963
Lines 98.303% (2607/2652) 👍 11.78
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review October 4, 2023 06:56
@efd6 efd6 requested a review from a team as a code owner October 4, 2023 06:56
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 force-pushed the 7924-infoblox_bloxone_ddi branch from 2bb32f3 to 0aadd8e Compare October 4, 2023 19:55
@efd6 efd6 force-pushed the 7924-infoblox_bloxone_ddi branch from 0aadd8e to 43bfb34 Compare October 4, 2023 19:56
@efd6 efd6 merged commit a754869 into elastic:main Oct 12, 2023
4 checks passed
@elasticmachine
Copy link

Package infoblox_bloxone_ddi - 1.11.2 containing this change is available at https://epr.elastic.co/search?package=infoblox_bloxone_ddi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:infoblox_bloxone_ddi Infoblox BloxOne DDI (DNS, DHCP, IP management)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infoblox BloxOne DDI] Failure to Ingest DHCP Lease Logs
3 participants