Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Redis Enterprise]Add dimension fields to node datastream for TSDB su… #8091

Merged
merged 8 commits into from
Nov 18, 2023
Merged

[Redis Enterprise]Add dimension fields to node datastream for TSDB su… #8091

merged 8 commits into from
Nov 18, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Oct 4, 2023 •
edited
Loading

Proposed commit message

  • This PR adds dimensions for node datastream of Redis Enterprise to support TSDB enablement.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

@ritalwar ritalwar requested a review from a team as a code owner October 4, 2023 14:02
@ritalwar ritalwar mentioned this pull request Oct 4, 2023
Closed
11 tasks
@elasticmachine
Copy link

elasticmachine commented Oct 4, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-16T06:58:36.401+0000

  • Duration: 15 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 4, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 50.0% (4/8) 👎 -47.531
Lines 100.0% (0/0) 💚 17.607
Conditionals 100.0% (0/0) 💚

agithomas
agithomas approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar added the enhancement New feature or request label Nov 1, 2023
@ritalwar ritalwar mentioned this pull request Nov 10, 2023
Merged
4 tasks
@ritalwar
Copy link
Contributor Author

/test

harnish-elastic
harnish-elastic approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit 4132ad3 into elastic:main Nov 18, 2023
4 checks passed
@elasticmachine
Copy link

Package redisenterprise - 0.8.0 containing this change is available at https://epr.elastic.co/search?package=redisenterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

@harnish-elastic harnish-elastic harnish-elastic approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ritalwar @elasticmachine @agithomas @harnish-elastic