Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bot fields to HTTP events in Cloudflare integrations #8093

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

chemamartinez
Copy link
Contributor

Proposed commit message

This pull request adds the following changes:

Cloudflare

  • Add support for BotScore and BotScoreSrc fields that appear in HTTP events.

Cloudflare Logpush

  • Add support for BotDetectionIDs field in HTTP Request events.

Didn't add BotDetectionIDs and BotTags fields to the Cloudflare integration because its documentation says that these fields are only available in Logpush v2. In addition, events provided by a customer that were collected by the Cloudflare integration don't contain them.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@chemamartinez chemamartinez marked this pull request as ready for review October 4, 2023 15:07
@chemamartinez chemamartinez requested a review from a team as a code owner October 4, 2023 15:07
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Oct 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-05T06:13:33.385+0000

  • Duration: 28 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 134
Skipped 0
Total 134

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 4, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (20/20) 💚
Files 100.0% (21/21) 💚
Classes 100.0% (21/21) 💚
Methods 100.0% (252/252) 💚
Lines 92.282% (5572/6038) 👎 -3.414
Conditionals 100.0% (0/0) 💚

@chemamartinez
Copy link
Contributor Author

/test

@chemamartinez chemamartinez merged commit 3593b7b into elastic:main Oct 5, 2023
4 checks passed
@elasticmachine
Copy link

Package cloudflare - 2.19.0 containing this change is available at https://epr.elastic.co/search?package=cloudflare

@elasticmachine
Copy link

Package cloudflare_logpush - 1.14.0 containing this change is available at https://epr.elastic.co/search?package=cloudflare_logpush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants