Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCP] Add Cloud Run docs #8096

Merged
merged 5 commits into from Nov 20, 2023
Merged

[GCP] Add Cloud Run docs #8096

merged 5 commits into from Nov 20, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Oct 4, 2023

Proposed commit message

Rename Cloud Run policy template title to cloudrun and add docs for metrics.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

andrewkroh added a commit to andrewkroh/integrations that referenced this pull request Oct 4, 2023
@andrewkroh
box_events - add changelog
91c16ec 
[git-generate]
elastic-package changelog add --link elastic#8096 --type enhancement --next minor --description "Modified the field definitions to reference ECS where possible and remove invalid field attributes."
@elasticmachine
Copy link

elasticmachine commented Oct 4, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-20T20:27:54.678+0000

  • Duration: 20 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 68
Skipped 0
Total 68

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 4, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 87.826% (101/115) ❕
Lines 95.124% (1502/1579) ❕
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 marked this pull request as ready for review October 5, 2023 11:15
@gpop63 gpop63 requested review from a team as code owners October 5, 2023 11:15
@gpop63 gpop63 requested a review from ishleenk17 October 5, 2023 11:15
@gpop63 gpop63 self-assigned this Oct 9, 2023
zmoog
zmoog approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gpop63, just for the records: IIRC, you successfully tested the upgrade path to make sure the name change does not create problems, right?

@gpop63 gpop63 merged commit 60302ad into elastic:main Nov 20, 2023
4 checks passed
@elasticmachine
Copy link

Package gcp - 2.31.1 containing this change is available at https://epr.elastic.co/search?package=gcp

@leandrojmp leandrojmp mentioned this pull request Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@ishleenk17 ishleenk17 Awaiting requested review from ishleenk17

Assignees

@gpop63 gpop63

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gpop63 @elasticmachine @zmoog