Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amazon_security_lake] Add data subscriber steps in readme #8113

Merged

Conversation

janvi-elastic
Copy link
Contributor

Type of change

  • Enhancement

What does this PR do?

  • Add data subscriber steps.
  • Remove agent installation steps.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/amazon_security_lake directory.
  • Run the following command to run tests.

elastic-package test

@janvi-elastic janvi-elastic requested a review from a team as a code owner October 6, 2023 09:01
@elasticmachine
Copy link

elasticmachine commented Oct 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-06T09:04:34.636+0000

  • Duration: 15 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 70.588% (12/17) 👎 -26.083
Classes 70.588% (12/17) 👎 -26.083
Methods 56.818% (50/88) 👎 -35.615
Lines 39.96% (3841/9612) 👎 -48.375
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamiehynds
Copy link

@ShourieG Crest don't have the ability to merge PR's. If it looks good to you, can you go ahead and merge please?

@ShourieG ShourieG merged commit 059c806 into elastic:main Oct 11, 2023
4 checks passed
@elasticmachine
Copy link

Package amazon_security_lake - 0.6.0 containing this change is available at https://epr.elastic.co/search?package=amazon_security_lake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants