Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integrations] - Improve docs & fix minor bugs for Microsoft exchange online message trace #8130

Merged
merged 5 commits into from Oct 12, 2023

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Oct 9, 2023

Type of change

  • Bug

Proposed commit message

  1. Improved documentation so now it redirects users to the recently updated official Microsoft docs.
  2. Updated the default value of scope as the existing value was wrong.
  3. Updated the default value for login url by removing a trailing / which could cause errors in authentication, if not updated by the user.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ShourieG ShourieG requested a review from a team as a code owner October 9, 2023 07:14
@ShourieG ShourieG self-assigned this Oct 9, 2023
@ShourieG ShourieG changed the title Bugfix/message trace [integrations] - Improve docs & fix minor bugs for Microsoft exchange online message trace Oct 9, 2023
@ShourieG ShourieG added integration Label used for meta issues tracking each integration Team:Security-External Integrations labels Oct 9, 2023
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Oct 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-12T10:16:36.286+0000

  • Duration: 24 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 9, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (15/15) 💚
Lines 98.106% (259/264)
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShourieG ShourieG merged commit af9ab41 into elastic:main Oct 12, 2023
4 checks passed
@ShourieG ShourieG deleted the bugfix/message_trace branch October 12, 2023 10:43
@elasticmachine
Copy link

Package microsoft_exchange_online_message_trace - 1.13.1 containing this change is available at https://epr.elastic.co/search?package=microsoft_exchange_online_message_trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration Label used for meta issues tracking each integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants