Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hashicorp Vault] Add metric_type mapping to metrics datastream #8132

Merged
merged 4 commits into from Oct 11, 2023

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Oct 9, 2023

  • Enhancement

Proposed commit message

  • WHAT: Added metric_type mapping to metrics datastream.
  • WHY : To benefit from the TSDB enablement of the package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry
  • Dashboard verification after adding dimensions field mapping (not part of this change)

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Oct 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-11T10:07:14.667+0000

  • Duration: 19 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 18
Skipped 0
Total 18

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 9, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 92.593% (25/27) 👎 -3.561
Lines 87.678% (185/211) 👎 -6.475
Conditionals 100.0% (0/0) 💚

@agithomas agithomas marked this pull request as ready for review October 11, 2023 06:01
@agithomas agithomas requested a review from a team as a code owner October 11, 2023 06:01
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, could you please change or comment on them before any merge? :)

packages/hashicorp_vault/manifest.yml Outdated Show resolved Hide resolved
packages/hashicorp_vault/manifest.yml Show resolved Hide resolved
@agithomas
Copy link
Contributor Author

@P1llus , can you confirm if bumping up the version to 8.9.0 is fine?

Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@P1llus
Copy link
Member

P1llus commented Oct 11, 2023

@agithomas thats fine, as long as the PR requires it then its not a problem to bump it.

@agithomas
Copy link
Contributor Author

/test

@agithomas agithomas merged commit c68cafb into elastic:main Oct 11, 2023
4 checks passed
@elasticmachine
Copy link

Package hashicorp_vault - 1.18.0 containing this change is available at https://epr.elastic.co/search?package=hashicorp_vault

@agithomas agithomas mentioned this pull request Oct 11, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants