Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prisma Cloud] Initial Release for Prisma Cloud #8135

Merged
merged 6 commits into from
Oct 23, 2023

Conversation

mohitjha-elastic
Copy link
Contributor

@mohitjha-elastic mohitjha-elastic commented Oct 9, 2023

What does this PR do?

  • Generated the skeleton of the Prisma Cloud integration package.
  • Added data stream.
  • Added data collection logic for the data stream.
  • Added the ingest pipeline for the data stream.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files.
  • Added test for pipeline for the data stream.

Integration release checklist

This checklist is intended for integrations maintainers to ensure consistency when creating or updating a Package, Module or Dataset for an Integration.

All changes

  • Change follows the contributing guidelines
  • Supported versions of the monitoring target is documented
  • Supported operating systems are documented (if applicable)
  • Integration or System tests exist
  • Documentation exists
  • Fields follow ECS and naming conventions
  • At least a manual test with ES / Kibana / Agent has been performed.
  • Required Kibana version set to: ^8.8.0

New Package

  • Screenshot of the "Add Integration" page on Fleet added

Log dataset changes

  • Pipeline tests exist (if applicable)
  • Generated output for at least 1 log file exists
  • Sample event (sample_event.json) exists

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/prisma_cloud directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Automated Test

test-file.txt

Screenshot

image
image

We are facing message size exceeding errors so need to validate it in the cloud instance.
image

@elasticmachine
Copy link

elasticmachine commented Oct 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-23T07:40:17.362+0000

  • Duration: 25 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 30
Skipped 0
Total 30

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@jamiehynds jamiehynds mentioned this pull request Oct 9, 2023
15 tasks
@P1llus
Copy link
Member

P1llus commented Oct 9, 2023

/test

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kcreddy
Copy link
Contributor

kcreddy commented Oct 10, 2023

/test

@elasticmachine
Copy link

elasticmachine commented Oct 10, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚
Classes 100.0% (5/5) 💚
Methods 94.118% (64/68) 👎 -2.132
Lines 94.914% (7017/7393) 👎 -5.086
Conditionals 100.0% (0/0) 💚

@@ -0,0 +1,4 @@
dependencies:
ecs:
reference: git@v8.9.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reference: git@v8.9.0
reference: git@v8.10.0

- set:
field: ecs.version
tag: set_ecs_version
value: 8.9.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.10.0 is now available.

vars:
url: http://{{Hostname}}:{{Port}}
preserve_original_event: true
preserve_duplicate_custom_fields: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add assert.hit_count to all system test configs?

@@ -0,0 +1,113 @@
format_version: 2.8.0
name: prisma_cloud
title: "Prisma Cloud"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update title to Palo Alto Prisma Cloud

@kcreddy
Copy link
Contributor

kcreddy commented Oct 13, 2023

/test

preserve_original_event: true
preserve_duplicate_custom_fields: true
assert:
hit_count: 500
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we getting 500 events? Where are these 500 events defined?

@leandrojmp
Copy link
Contributor

Hello, just curious, is this integration planned for 8.10 or just 8.11?

@mohitjha-elastic
Copy link
Contributor Author

Hello, just curious, is this integration planned for 8.10 or just 8.11?

Hey @leandrojmp, We have planned it for 8.10.1.

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"user": state.user,
"password": state.password,
"batch_size": string(state.batch_size),
"access_token": state.access_token,
Copy link
Contributor

@kcreddy kcreddy Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could save this token in redact config next release

@kcreddy kcreddy merged commit f6cc2d1 into elastic:main Oct 23, 2023
3 checks passed
@elasticmachine
Copy link

Package prisma_cloud - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=prisma_cloud

@leandrojmp
Copy link
Contributor

leandrojmp commented Oct 24, 2023

Hello,

We are planning to test this integration, but one question, is the Incident Audit dataset only available when using TCP/UDP? The datastreams for this dataset only have those two inputs available.

Not sure if this is a limitation of the Prisma Cloud tool or the integration.

EDIT:

Just saw this in the notes:

Currently, we are unable to collect logs of Incident Audit datastream via defined API. Hence, we have not added the configuration of Incident Audit data stream via REST API.

@mohitjha-elastic mohitjha-elastic deleted the prisma_cloud-0.1.0 branch October 25, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Palo Alto Prisma Cloud
7 participants