Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws] Remove unused aws.*.metrics.*.* and aws.s3.bucket.name #8140

Merged
merged 6 commits into from Oct 26, 2023

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 9, 2023

Proposed commit message

This PR is to remove unused aws.*.metrics.*.* and aws.s3.bucket.name from package-fields.yml file.
For some data streams when defining what metrics to collect from CloudWatch, specific metric names are listed. With the list of specific metrics, aws.*.metrics.*.* is redundant. Some data stream when defining what metrics to collect, it only specifies the namespace for CloudWatch. That way we will keep the aws.*.metrics.*.* just in case AWS adds more metrics.

For aws.s3.bucket.name it is only used in s3_daily_storage and s3_request data streams in AWS integration. Will remove the rest.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng kaiyan-sheng self-assigned this Oct 9, 2023
@elasticmachine
Copy link

elasticmachine commented Oct 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-26T04:35:06.788+0000

  • Duration: 59 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 212
Skipped 3
Total 215

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 9, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👎 -5.556
Classes 94.444% (17/18) 👎 -5.556
Methods 86.047% (259/301) 👎 -6.261
Lines 86.083% (7571/8795) 👎 -5.494
Conditionals 100.0% (0/0) 💚

@kaiyan-sheng kaiyan-sheng marked this pull request as ready for review October 11, 2023 15:09
@kaiyan-sheng kaiyan-sheng requested review from a team as code owners October 11, 2023 15:09
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhapas
Copy link
Contributor

bhapas commented Oct 26, 2023

/test

Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaiyan-sheng kaiyan-sheng merged commit 072996d into elastic:main Oct 26, 2023
4 checks passed
@kaiyan-sheng kaiyan-sheng deleted the fields_aws branch October 26, 2023 17:04
@elasticmachine
Copy link

Package aws - 2.8.4 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants