Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Logs Nginx Ingress Controller] Migrate Nginx Ingress Controller Access and Error Dashboard to lens #8143

Conversation

kush-elastic
Copy link
Collaborator

@kush-elastic kush-elastic commented Oct 10, 2023

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate Nginx Ingress Controller visualizations to the lens in the current Kibana version 8.6.0 itself.

  • Statistics for Nginx Ingress Controller Lens migration:

Migration stats

  Before Migration   After Migration  
  Lens Vizualization Lens Vizualization
[Logs Nginx Ingress Controller] Access and error logs 0 3 3 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.6.0 itself.

Related issues

Before Migration
nginx-ingress-controller-access-error-logs

After Migration
nginx-ingress-controller-access-error-logs

@elasticmachine
Copy link

elasticmachine commented Oct 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-11T09:02:08.835+0000

  • Duration: 14 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 16
Skipped 0
Total 16

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 10, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 3.346
Classes 100.0% (2/2) 💚 3.346
Methods 92.0% (23/25) 👎 -0.557
Lines 94.461% (324/343) 👍 6.053
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…nto 7812-nginx-ingress-controller-lens-migration-access-error-dashboard
@kush-elastic kush-elastic merged commit 207e0ce into elastic:main Oct 11, 2023
4 checks passed
@elasticmachine
Copy link

Package nginx_ingress_controller - 1.8.2 containing this change is available at https://epr.elastic.co/search?package=nginx_ingress_controller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y][Nginx Ingress controller] Nginx Ingress controller Lens migration
4 participants