Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tenable_io] Update Interval and Initial Interval of Asset, Vulnerability and Plugin Data Stream for Tenable IO #8144

Merged
merged 3 commits into from Oct 13, 2023

Conversation

mohitjha-elastic
Copy link
Contributor

Type of change

  • Enhancement

What does this PR do?

  • Change Interval and Initial interval of Asset, Vulnerability, and Plugin Data Stream for Tenable IO.
  • Updated user-agent in the header for all the data streams.
  • Updated the type of interval from text to select in the scan data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Clone integrations repo.
Install the elastic package locally.
Start the elastic stack using the elastic package.
Move to the integrations/packages/tenable_io directory.
Run the following command to run tests.

Automated Test

test-file.txt

…in. Use select type for the interval parameter in scan data stream. Updated user-agent in data collection for all the data stream
@mohitjha-elastic mohitjha-elastic requested a review from a team as a code owner October 10, 2023 09:26
@mohitjha-elastic mohitjha-elastic changed the title Change interval and initial interval of asset, vulnerability and plug… [tenable_io] Update Interval and Initial Interval of Asset, Vulnerability and Plugin Data Stream for Tenable IO Oct 10, 2023
@elasticmachine
Copy link

elasticmachine commented Oct 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-13T07:44:20.199+0000

  • Duration: 18 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@kcreddy
Copy link
Contributor

kcreddy commented Oct 10, 2023

/test

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reference issue and reason for modifying/removing the interval and initial_interval values?

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "2.3.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- version: "2.3.1"
- version: "2.4.0"

Since it is an enhancement and not a fix.

@elasticmachine
Copy link

elasticmachine commented Oct 10, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 98.0% (49/50) 👍 11.333
Lines 92.005% (2152/2339) 👎 -1.108
Conditionals 100.0% (0/0) 💚

@mohitjha-elastic
Copy link
Contributor Author

Is there any reference issue and reason for modifying/removing the interval and initial_interval values?

These changes have been discussed over the email with the tenable. @jamiehynds is aware of it.

@kcreddy
Copy link
Contributor

kcreddy commented Oct 13, 2023

/test

@kcreddy kcreddy merged commit 5d4eaaa into elastic:main Oct 13, 2023
4 checks passed
@elasticmachine
Copy link

Package tenable_io - 2.4.0 containing this change is available at https://epr.elastic.co/search?package=tenable_io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants