Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redis Enterprise] Add dimension fields to proxy datastream. #8148

Merged

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Oct 10, 2023

Proposed commit message

This PR adds the dimension field mappings for the proxy datastream of Redis Enterprise to support TSDB enablement.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

TSDB Tests

proxy

You're testing with version 8.9.0.

Testing data stream metrics-redisenterprise.proxy-default.
Index being used for the documents is .ds-metrics-redisenterprise.proxy-default-2023.11.24-000001.
Index being used for the settings and mappings is .ds-metrics-redisenterprise.proxy-default-2023.11.24-000002.

The time series fields for the TSDB index are: 
        - dimension (17 fields):
                - agent.id
                - cloud.account.id
                - cloud.availability_zone
                - cloud.instance.id
                - cloud.provider
                - cloud.region
                - container.id
                - host.name
                - redisenterprise.proxy.labels.bdb
                - redisenterprise.proxy.labels.cluster
                - redisenterprise.proxy.labels.endpoint
                - redisenterprise.proxy.labels.instance
                - redisenterprise.proxy.labels.job
                - redisenterprise.proxy.labels.node
                - redisenterprise.proxy.labels.port
                - redisenterprise.proxy.labels.proxy
                - service.address
        - routing_path (17 fields):
                - agent.id
                - cloud.account.id
                - cloud.availability_zone
                - cloud.instance.id
                - cloud.provider
                - cloud.region
                - container.id
                - host.name
                - redisenterprise.proxy.labels.bdb
                - redisenterprise.proxy.labels.cluster
                - redisenterprise.proxy.labels.endpoint
                - redisenterprise.proxy.labels.instance
                - redisenterprise.proxy.labels.job
                - redisenterprise.proxy.labels.node
                - redisenterprise.proxy.labels.port
                - redisenterprise.proxy.labels.proxy
                - service.address

Index tsdb-index-enabled successfully created.

Copying documents from .ds-metrics-redisenterprise.proxy-default-2023.11.24-000001 to tsdb-index-enabled...
All 34 documents taken from index .ds-metrics-redisenterprise.proxy-default-2023.11.24-000001 were successfully placed to index tsdb-index-enabled.

@ritalwar ritalwar requested a review from a team as a code owner October 10, 2023 11:08
@ritalwar ritalwar mentioned this pull request Oct 10, 2023
11 tasks
@elasticmachine
Copy link

elasticmachine commented Oct 10, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-24T07:09:59.703+0000

  • Duration: 15 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 10, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 5.556
Classes 100.0% (0/0) 💚 5.556
Methods 50.0% (4/8) 👎 -39.701
Lines 100.0% (0/0) 💚 13.917
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar added the enhancement New feature or request label Nov 1, 2023
@ritalwar ritalwar changed the title [Redis Enterprise] Add dimension fields to proxy datastream for TSDB … [Redis Enterprise] Add dimension fields to proxy datastream. Nov 1, 2023
Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit 9d12816 into elastic:main Nov 27, 2023
4 checks passed
@elasticmachine
Copy link

Package redisenterprise - 0.8.2 containing this change is available at https://epr.elastic.co/search?package=redisenterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants