[HA Proxy ]Corrected incorrect aggregation function used in visualisation and dashboard

[agithomas]

• Bug

Details

HAProxy dashboard uses incorrect aggregation functions in multiple dashboards and visualisation.

For all the fields that are having metric_type as counter, sum() function is used presently in the dashboard. This shows incorrect values in the dashboard compared to the /stats dashboard of haproxy.

All sum() functions are replaced with max() functions when field is having metric_type counter. This correction is also needed for TSDB compatibility for counter type fields to not show errors when using sum() function

Proposed commit message

HAProxy dashboard uses incorrect aggregation functions in multiple dashboards and visualisation. This is corrected in this version.

Checklist

• I have reviewed tips for building integrations and this pull request is aligned with them.
• I have verified that all data streams collect metrics or logs.
• I have added an entry to my package's changelog.yml file.
• I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

• [ ]

How to test this PR locally

Related issues

• Relates [HA Proxy] TSDB Enablement #7138

Screenshots

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-10-18T11:12:15.844+0000

• Duration: 14 min 58 sec

Test stats 🧪

Test	Results
Failed	0
Passed	40
Skipped	0
Total	40

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[elasticmachine]

🌐 Coverage report

Name	Metrics % (covered/total)	Diff
Packages	100.0% (1/1)	💚
Files	100.0% (1/1)	💚 2.5
Classes	100.0% (1/1)	💚 2.5
Methods	90.476% (19/21)	👎 -0.433
Lines	97.312% (181/186)	👍 2.845
Conditionals	100.0% (0/0)	💚

[agithomas]

Verification check for timeseries enablement - info datastream

hidden": "true",
      "time_series": {
        "end_time": "2023-10-16T15:26:19.000Z",
        "start_time": "2023-10-16T11:26:19.000Z"
      },
      "provided_name": ".ds-metrics-haproxy.info-default-2023.10.16-000002",

time_series mapping

[agithomas]

Verification check for timeseries enablement in stats datastream

      "time_series": {
        "end_time": "2023-10-16T15:35:18.000Z",
        "start_time": "2023-10-16T11:26:19.000Z"
      },

metric_type mapping

[ritalwar]

LGTM!

[lalit-satapathy]

uses incorrect aggregation functions in multiple dashboards and visualisation.

@agithomas, Can we briefly summarise the issues in the earlier aggregation and what was fixed. It's rather tricky to get a summary from the json file changes.

[agithomas]

@agithomas, Can we briefly summarise the issues in the earlier aggregation and what was fixed. It's rather tricky to get a summary from the json file changes.

For all the fields that are having metric_type as counter, sum() function is used presently in the dashboard. This shows incorrect values in the dashboard compared to the /stats dashboard of haproxy.

All sum() functions are replaced with max() functions when field is having metric_type counter. This correction is also needed for TSDB compatibility for counter type fields to not show errors when using sum() function

[elasticmachine]

Package haproxy - 1.8.6 containing this change is available at https://epr.elastic.co/search?package=haproxy