[salesforce] Update package to format_version 3.0.0 #8215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommyers-elastic
force-pushed
the
update-salesforce-to-format-version-3
branch
from
1fe5ef1
to
8526ae7
Compare
96 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
jsoriano
reviewed
Oct 16, 2023
There was a problem hiding this comment.
@jsoriano is there any way we could make changes in the validation for cases like this to avoid the added overhead in the ingest pipelines?
This validation was already introduced in Package Spec v2.
Try to use append instead of script for this case.
packages/salesforce/data_stream/apex/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
shmsr
reviewed
Oct 16, 2023
packages/salesforce/data_stream/apex/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
tommyers-elastic
force-pushed
the
update-salesforce-to-format-version-3
branch
from
299c256
to
6d8611b
Compare
|
LGTM. Although, CI failed. Format required. |
tommyers-elastic
force-pushed
the
update-salesforce-to-format-version-3
branch
from
6d8611b
to
0ad50ba
Compare
shmsr
approved these changes
Oct 17, 2023
|
Package salesforce - 0.11.0 containing this change is available at https://epr.elastic.co/search?package=salesforce |
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change here is the modification of the simple
renameprocessors toscriptin order to get the formatting of the list the way elastic-package wants it. I'm not sold on these changes, since it adds complexity for no change in behaviour.@jsoriano is there any way we could make changes in the validation for cases like this to avoid the added overhead in the ingest pipelines?