Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate obs-infraobs-integrations to package-spec v3 #5 #8234

Merged

Conversation

shmsr
Copy link
Member

@shmsr shmsr commented Oct 18, 2023

Cherry-picked changes for 2 packages to this branch so that #8171 gets unblocked:

  • mongodb
  • influxdb

Proposed commit message

Migrate the following package to use package-spec v3:

  • mongodb
  • influxdb

Here influxdb ci is failing for some unknown reason i.e., it failing with an error where it shouldn't. And mongodb needs to be tested to check if no data loss is there (tsdb).

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@elasticmachine
Copy link

elasticmachine commented Oct 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-23T09:58:59.012+0000

  • Duration: 18 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 32
Skipped 0
Total 32

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 18, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 92.683% (38/41) 👎 -1.132
Lines 68.217% (88/129) 👎 -14.176
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - only question is about addition of beta release tags to data streams. thanks!

@shmsr shmsr requested a review from a team October 18, 2023 16:05
@shmsr shmsr self-assigned this Oct 18, 2023
@shmsr
Copy link
Member Author

shmsr commented Oct 18, 2023

@tommyers-elastic Do you know someone who can help with the CI issue we're facing with influxdb?

Ref: #8171 (comment)

@shmsr
Copy link
Member Author

shmsr commented Oct 19, 2023

#8028 (comment)

We're good with mongodb tsdb testing ^^

@shmsr
Copy link
Member Author

shmsr commented Oct 23, 2023

Upgraded the stack version for influxdb to ^8.9.0 to fix the constant CI failures:

Error: error running package system tests: could not complete test run: failed to install package: can't install the package: could not zip-install package; API status code = 500; response body = {"statusCode":500,"error":"Internal Server Error","message":"illegal_argument_exception\n\tRoot causes:\n\t\tillegal_argument_exception: Limit of total dimension fields [21] has been exceeded"}

@shmsr
Copy link
Member Author

shmsr commented Oct 23, 2023

@tommyers-elastic Should I merge this PR?

@tommyers-elastic
Copy link
Contributor

i'm happy to upgrade the stack version to make the CI more reliable. @lalit-satapathy how about you?

@lalit-satapathy
Copy link
Collaborator

i'm happy to upgrade the stack version to make the CI more reliable. @lalit-satapathy how about you?

@shmsr, Is the new conclusion that the CI is passing in 8.9.* and failing in 8.8.* for dimension_fields override? Our earlier understanding as per this, lead to conclude that, the issue is resolved in 8.8.* onwards.

I am fine, in that is case to upgrade to 8.9. Need to summarise and to see if any changes needed in other packages. Example kafka?

CC: @agithomas

@shmsr
Copy link
Member Author

shmsr commented Oct 25, 2023

i'm happy to upgrade the stack version to make the CI more reliable. @lalit-satapathy how about you?

@shmsr, Is the new conclusion that the CI is passing in 8.9.* and failing in 8.8.* for dimension_fields override? Our earlier understanding as per this, lead to conclude that, the issue is resolved in 8.8.* onwards.

I am fine, in that is case to upgrade to 8.9. Need to summarise and to see if any changes needed in other packages. Example kafka?

CC: @agithomas

For some unknown reason it is only happening for influxdb and this is the reason why I pulled out influxdb from #8171 to unblock that PR from merging.

After failing to conclude why the CI failed for influxdb, I tried reproducing this locally, and there too the tests were failing with with 8.8.0 stack. But for 8.9.0 it passed.

@lalit-satapathy
Copy link
Collaborator

For some unknown reason it is only happening for influxdb and this is the reason

So long as it consistently passes in 8.9 and fails in 8.8, we can conclude that some external change done in 8.9 stack.

@tommyers-elastic tommyers-elastic merged commit 18bf78a into elastic:main Oct 25, 2023
4 checks passed
@shmsr shmsr deleted the migrate-infraobs-ps-v3-batch-5-serverless branch October 25, 2023 09:06
@elasticmachine
Copy link

Package influxdb - 0.7.0 containing this change is available at https://epr.elastic.co/search?package=influxdb

@elasticmachine
Copy link

Package mongodb - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=mongodb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants