Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update IIS README to use documentation guidelines #8241

Merged
merged 4 commits into from Oct 30, 2023

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Oct 18, 2023

Proposed commit message

Update README to use documentation guidelines

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

View the README.

Related issues

Related to elastic/observability-docs#3270

@colleenmcginnis colleenmcginnis added enhancement New feature or request Team:Docs Label for the Observability docs team docs labels Oct 18, 2023
@colleenmcginnis colleenmcginnis self-assigned this Oct 18, 2023
@elasticmachine
Copy link

elasticmachine commented Oct 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-30T19:08:38.155+0000

  • Duration: 14 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 18, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 86.111% (31/36)
Lines 96.143% (349/363)
Conditionals 100.0% (0/0) 💚

Copy link

@SubhrataK SubhrataK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@colleenmcginnis colleenmcginnis marked this pull request as ready for review October 23, 2023 15:16
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner October 23, 2023 15:16
Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving the documentation 🎉

packages/iis/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/iis/_dev/build/docs/README.md Outdated Show resolved Hide resolved
@elasticmachine
Copy link

Package iis - 1.17.1 containing this change is available at https://epr.elastic.co/search?package=iis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement New feature or request Team:Docs Label for the Observability docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants