Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][K8s] Migrate Cronjobs dashboard visualizations to lens #8263

Merged
merged 3 commits into from
Oct 27, 2023
Merged

[O11y][K8s] Migrate Cronjobs dashboard visualizations to lens #8263

merged 3 commits into from
Oct 27, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Oct 23, 2023 •
edited
Loading

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate K8s CronJobs visualizations to the lens in the current Kibana version 8.10.2 itself.

  • Statistics for K8s CronJobs Lens migration:

Migration stats

  Before Migration   After Migration  
  Lens Vizualization Lens Vizualization
[Metrics Kubernetes] Cronjobs 1 1 2 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.10.2 itself.

Related issues

Before Migration:
image
After Migration:
kubernetes-state_cronjob-dashboard

@rajvi-patel-22 rajvi-patel-22 self-assigned this Oct 23, 2023
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Oct 23, 2023
Closed
9 tasks
@elasticmachine
Copy link

elasticmachine commented Oct 23, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-27T05:42:25.439+0000

  • Duration: 52 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 94
Skipped 0
Total 94

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 23, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 4.451
Classes 100.0% (1/1) 💚 4.451
Methods 96.25% (77/80) 👍 4.768
Lines 100.0% (22/22) 💚 11.773
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review October 23, 2023 06:10
@rajvi-patel-22 rajvi-patel-22 requested review from a team as code owners October 23, 2023 06:10
@rajvi-patel-22 rajvi-patel-22 changed the title [O11y][K8] Migrate Cronjobs dashboard visualizations to lens [O11y][K8s] Migrate Cronjobs dashboard visualizations to lens Oct 23, 2023
kush-elastic
kush-elastic approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drewdaemon
Copy link
Contributor

drewdaemon commented Oct 23, 2023 •
edited
Loading

Thanks for doing this. Could we decrease the height of the metric panel by about half? That way the number will be much closer to the label.

@rajvi-patel-22
Copy link
Contributor Author

rajvi-patel-22 commented Oct 26, 2023 •
edited
Loading

Thanks for doing this. Could we decrease the height of the metric panel by about half? That way the number will be much closer to the label.

@drewdaemon , according to your comment I have raised a separate issue for tracking the changes related to size of metric visualizations. As already 3 dashboard PRs are merged for Kubernetes, they also require this change.

@drewdaemon
Copy link
Contributor

Thanks @rajvi-elastic !

drewdaemon
drewdaemon approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the understanding that metric height will be addressed in #8308

mbondyra
mbondyra approved these changes Oct 26, 2023
View reviewed changes
Copy link

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@rajvi-patel-22
Merge branch 'main' of https://github.com/rajvi-elastic/integrations …
4e7e0f8 
…into lens_migration_k8_cronjob

Conflicts:
	packages/kubernetes/changelog.yml
	packages/kubernetes/manifest.yml
@rajvi-patel-22 rajvi-patel-22 merged commit 29ec02c into elastic:main Oct 27, 2023
4 checks passed
@elasticmachine
Copy link

Package kubernetes - 1.50.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

@mbondyra mbondyra mbondyra approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

@constanca-m constanca-m constanca-m approved these changes

@MichaelKatsoulis MichaelKatsoulis Awaiting requested review from MichaelKatsoulis MichaelKatsoulis is a code owner automatically assigned from elastic/obs-cloudnative-monitoring

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rajvi-patel-22 @elasticmachine @drewdaemon @mbondyra @kush-elastic @constanca-m