Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][K8s] Migrate StatefulSets dashboard visualizations to lens #8264

Merged
merged 3 commits into from Oct 23, 2023
Merged

[O11y][K8s] Migrate StatefulSets dashboard visualizations to lens #8264

merged 3 commits into from Oct 23, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Oct 23, 2023 •
edited

Urgency

  • High

Activity Type

  • Enhancement

What does this PR do?

  • Manually migrate K8s StatefulSets visualizations to the lens in the current Kibana version 8.10.2 itself.

  • Statistics for K8s StatefulSets Lens migration:

Migration stats

  Before Migration   After Migration  
  Lens Vizualization Lens Vizualization
[Metrics Kubernetes] StatefulSets 1 5 6 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.10.2 itself.

Related issues

Before Migration:
image
After Migration:
kubernetes-state_statefulset-dashboard

@rajvi-patel-22 rajvi-patel-22 self-assigned this Oct 23, 2023
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Oct 23, 2023
Closed
9 tasks
@elasticmachine
Copy link

elasticmachine commented Oct 23, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-23T08:03:17.634+0000

  • Duration: 53 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 94
Skipped 0
Total 94

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 23, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 96.25% (77/80) 👎 -1.388
Lines 100.0% (22/22) 💚 0.79
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review October 23, 2023 06:51
@rajvi-patel-22 rajvi-patel-22 requested review from a team as code owners October 23, 2023 06:51
@rajvi-patel-22 rajvi-patel-22 changed the title [O11y][K8] Migrate StatefulSets dashboard visualizations to lens [O11y][K8s] Migrate StatefulSets dashboard visualizations to lens Oct 23, 2023
kush-elastic
kush-elastic approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22
Merge branch 'main' of https://github.com/rajvi-elastic/integrations …
563d076 
…into lens_migration_k8_stateful

Conflicts:
	packages/kubernetes/changelog.yml
@rajvi-patel-22 rajvi-patel-22 merged commit 7897c77 into elastic:main Oct 23, 2023
4 checks passed
@elasticmachine
Copy link

Package kubernetes - 1.48.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gizas gizas gizas approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

@constanca-m constanca-m Awaiting requested review from constanca-m constanca-m is a code owner automatically assigned from elastic/obs-cloudnative-monitoring

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rajvi-patel-22 @elasticmachine @gizas @kush-elastic