Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for AD Logs #8275

Merged
merged 5 commits into from Nov 30, 2023

Conversation

tdancheva
Copy link
Contributor

@tdancheva tdancheva commented Oct 24, 2023

Proposed commit message

I updated the documentation for AD Logs regarding eventhub and connection_string settings to avoid confusion with namespace, as a follow-up of an SDH.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@tdancheva tdancheva added enhancement New feature or request Team:Docs Label for the Observability docs team docs labels Oct 24, 2023
@tdancheva tdancheva self-assigned this Oct 24, 2023
@tdancheva tdancheva requested a review from a team as a code owner October 24, 2023 11:07
@tdancheva tdancheva requested a review from zmoog October 24, 2023 11:08
@elasticmachine
Copy link

elasticmachine commented Oct 24, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-29T16:58:10.879+0000

  • Duration: 15 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 24, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22) 👎 -13.636
Classes 86.364% (19/22) 👎 -13.636
Methods 83.333% (155/186) 👍 58.333
Lines 85.021% (2821/3318) 👎 -14.979
Conditionals 100.0% (0/0) 💚

@botelastic
Copy link

botelastic bot commented Nov 25, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Nov 25, 2023
@botelastic botelastic bot removed the Stalled label Nov 29, 2023
@tdancheva tdancheva merged commit 9cb5163 into elastic:main Nov 30, 2023
4 checks passed
@elasticmachine
Copy link

Package azure - 1.8.1 containing this change is available at https://epr.elastic.co/search?package=azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement New feature or request Team:Docs Label for the Observability docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants