Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qualys_vmdr: add request tracer logging #8290

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Oct 25, 2023

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Oct 25, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-27T11:58:53.249+0000

  • Duration: 18 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 25, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 5.263
Classes 100.0% (2/2) 💚 5.263
Methods 100.0% (26/26) 💚 15.152
Lines 95.924% (2118/2208) 👍 9.616
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review October 25, 2023 08:29
@efd6 efd6 requested a review from a team as a code owner October 25, 2023 08:29
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@chrisberkhout chrisberkhout self-requested a review October 26, 2023 15:32
Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw the changes missing in packages/qualys_vmdr/data_stream/asset_host_detection/agent/stream/input.yml.hbs after initial review.

@chrisberkhout chrisberkhout merged commit 1688326 into elastic:main Oct 27, 2023
4 checks passed
@elasticmachine
Copy link

Package qualys_vmdr - 0.6.0 containing this change is available at https://epr.elastic.co/search?package=qualys_vmdr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants