Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STAN] Enable TSDB #8333

Merged
merged 3 commits into from
Nov 21, 2023
Merged

[STAN] Enable TSDB #8333

merged 3 commits into from
Nov 21, 2023

Conversation

gpop63
Copy link
Contributor

@gpop63 gpop63 commented Oct 30, 2023

Overview

Enables TSDB for metrics data streams:

  • channels
  • stats
  • subscriptions

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

scrnli_10_30_2023_1-47-39 PM

@elasticmachine
Copy link

elasticmachine commented Oct 30, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-20T15:32:38.052+0000

  • Duration: 20 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 16
Skipped 0
Total 16

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 30, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (20/20) 💚
Lines 95.477% (190/199) 👎 -4.523
Conditionals 100.0% (0/0) 💚

@gpop63 gpop63 marked this pull request as ready for review October 30, 2023 13:11
@gpop63 gpop63 requested a review from a team as a code owner October 30, 2023 13:11
@gpop63 gpop63 mentioned this pull request Oct 30, 2023
Closed
17 tasks
lalit-satapathy
lalit-satapathy approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gpop63 gpop63 merged commit 755fff6 into elastic:main Nov 21, 2023
4 checks passed
@elasticmachine
Copy link

Package stan - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=stan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalit-satapathy lalit-satapathy lalit-satapathy approved these changes

@constanca-m constanca-m constanca-m approved these changes

@tetianakravchenko tetianakravchenko Awaiting requested review from tetianakravchenko tetianakravchenko was automatically assigned from elastic/obs-cloudnative-monitoring

@agithomas agithomas Awaiting requested review from agithomas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

STAN TSDB Enablement
4 participants
@gpop63 @elasticmachine @lalit-satapathy @constanca-m