Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitwarden] Add support for the member data stream #8352

Merged
merged 3 commits into from Nov 1, 2023

Conversation

brijesh-elastic
Copy link
Contributor

Type of change

  • Enhancement

What does this PR do?

All changes

  • Change follows the contributing guidelines
  • Supported versions of the monitoring target is documented
  • Supported operating systems are documented (if applicable)
  • Integration or System tests exist
  • Documentation exists
  • Fields follow ECS and naming conventions
  • At least a manual test with ES / Kibana / Agent has been performed.
  • Required Kibana version set to: ^8.4.1

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/bitwarden directory.
  • Run the following command to run tests.

elastic-package test

Related issue

Closes #7246

Automated Test

test-bitwarden.txt

@brijesh-elastic brijesh-elastic requested a review from a team as a code owner October 31, 2023 13:10
@elasticmachine
Copy link

elasticmachine commented Oct 31, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-01T06:51:31.018+0000

  • Duration: 18 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 32
Skipped 0
Total 32

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 31, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 6.25
Classes 100.0% (5/5) 💚 6.25
Methods 100.0% (56/56) 💚 21.698
Lines 95.152% (1374/1444) 👍 1.39
Conditionals 100.0% (0/0) 💚

fields:
- name: access_all
type: boolean
description: Determines if this member can access all collections within the organization, or only the associated collections. If set to {true}, this option overrides any collection assignments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Determines if this member can access all collections within the organization, or only the associated collections. If set to {true}, this option overrides any collection assignments.
description: Determines if this member can access all collections within the organization, or only the associated collections. If set to true, this option overrides any collection assignments.

or

Suggested change
description: Determines if this member can access all collections within the organization, or only the associated collections. If set to {true}, this option overrides any collection assignments.
description: Determines if this member can access all collections within the organization, or only the associated collections. If set to `true`, this option overrides any collection assignments.

Its unclear to me why they used curlies for this in the swagger definition; it's not a parameter and the description is not a parameterisable entity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will Update it.

description: Organization user status type value.
- name: two_factor_enabled
type: boolean
description: Returns {true} if the member has a two-step login method enabled on their user account.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

- name: interval
type: text
title: Interval
description: "Duration between requests to the Bitwarden. NOTE: Supported units for this parameter are h/m/s."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "Duration between requests to the Bitwarden. NOTE: Supported units for this parameter are h/m/s."
description: "Duration between requests to the Bitwarden. Supported units for this parameter are h/m/s."

@efd6
Copy link
Contributor

efd6 commented Nov 1, 2023

/test

@efd6 efd6 merged commit c3fcfbf into elastic:main Nov 1, 2023
4 checks passed
@elasticmachine
Copy link

Package bitwarden - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=bitwarden

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bitwarden] Enrich event fields with information from members
3 participants