Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cisco Meraki] Simplify ipflows pipeline to cover ICMP events #8354

Merged
merged 3 commits into from Nov 2, 2023

Conversation

chemamartinez
Copy link
Contributor

Proposed commit message

Several dissect processors have been replaced by a kv processor that makes the processing of ip_flow events less restrictive, so now ICMP events are also processed as well as TCP/UDP ones.

The changes related to this fix are applied in the ipflows ingest pipeline and the test file test-ip-flow.log. Further changes in the pull request are a consequence of unrelated changes that fixed the format of some special characters when running pipeline tests.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Added pipeline test case to verify the processors handle ICMP events properly.

@chemamartinez chemamartinez marked this pull request as ready for review October 31, 2023 13:53
@chemamartinez chemamartinez requested a review from a team as a code owner October 31, 2023 13:53
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Oct 31, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-01T17:10:02.677+0000

  • Duration: 19 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 100.0% (67/67) 💚
Lines 98.157% (1172/1194)
Conditionals 100.0% (0/0) 💚

@chemamartinez chemamartinez merged commit 5d5aec7 into elastic:main Nov 2, 2023
4 checks passed
@elasticmachine
Copy link

Package cisco_meraki - 1.18.0 containing this change is available at https://epr.elastic.co/search?package=cisco_meraki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants