Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update MSSQL README #8360

Merged
merged 2 commits into from Nov 1, 2023

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Oct 31, 2023

Addresses feedback provided after #8240 was merged. See review comments: #8240 (review)

Proposed commit message

Update documentation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

View the README.

Related issues

Related to #8240

@colleenmcginnis colleenmcginnis added enhancement New feature or request Team:Docs Label for the Observability docs team docs labels Oct 31, 2023
@colleenmcginnis colleenmcginnis self-assigned this Oct 31, 2023
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner October 31, 2023 20:25
@elasticmachine
Copy link

elasticmachine commented Oct 31, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-31T20:27:10.932+0000

  • Duration: 70 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 93.75% (30/32)
Lines 100.0% (1252/1252) 💚
Conditionals 100.0% (0/0) 💚

Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@colleenmcginnis colleenmcginnis merged commit bb17ebd into elastic:main Nov 1, 2023
4 checks passed
@colleenmcginnis colleenmcginnis deleted the pr-8240-follow-up branch November 1, 2023 14:18
@elasticmachine
Copy link

Package microsoft_sqlserver - 2.3.2 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs enhancement New feature or request Team:Docs Label for the Observability docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants