Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mandiant Advantage Integration initial implementation #8390

Merged
merged 5 commits into from
Nov 14, 2023
Merged

Mandiant Advantage Integration initial implementation #8390

merged 5 commits into from
Nov 14, 2023

Conversation

miguelhdezsob
Copy link
Contributor

@miguelhdezsob miguelhdezsob commented Nov 2, 2023 •
edited
Loading

Summary of PR

  • Generated the skeleton of the Mandiant Advantage integration package.
  • Added data streams.
  • Added data collection logic for all the data streams.
  • Added the ingest pipeline for all the data streams.
  • Mapped fields according to the ECS schema and added Fields metadata in the appropriate yml files.
  • Added dashboards and visualizations.
  • Added test for pipeline for all the data streams.
  • Added system test cases for all the data streams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Update PR number in changelog once created

How to test this PR locally

Pull the code locally and run elastic-package test. You might also want to build and manually install the integration if needed.

Related issues

  • N/A

Screenshots

image
image
image

@elasticmachine
Copy link

elasticmachine commented Nov 2, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-09T18:55:28.869+0000

  • Duration: 16 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@miguelhdezsob miguelhdezsob changed the title Add initial implementation of Mandiant Advantage Integration [New Integration] Mandiant Advantage Integration Nov 2, 2023
@miguelhdezsob miguelhdezsob changed the title [New Integration] Mandiant Advantage Integration Mandiant Advantage Integration initial implementation Nov 2, 2023
@jamiehynds jamiehynds requested a review from a team November 3, 2023 09:27
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kgeller
Copy link
Contributor

kgeller commented Nov 7, 2023

/test

@kgeller
Copy link
Contributor

kgeller commented Nov 7, 2023 

Error: there is no owner for "packages/ti_mandiant_advantage" in ".github/CODEOWNERS"
--
  | 🚨 Error: The command exited with status 1

Currently the build is failing because there's no entry in codeowners. Once that gets added, we should get a 'real' run of CI

@miguelhdezsob
Copy link
Contributor Author 

Error: there is no owner for "packages/ti_mandiant_advantage" in ".github/CODEOWNERS"
--
  | 🚨 Error: The command exited with status 1

Currently the build is failing because there's no entry in codeowners. Once that gets added, we should get a 'real' run of CI

Thanks for the review! I believe I have addressed your comments and added the CODEOWNERS entry. This should be ready for another review.

@kgeller
Copy link
Contributor

kgeller commented Nov 8, 2023

/test

@elasticmachine
Copy link

elasticmachine commented Nov 8, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.79
Classes 100.0% (1/1) 💚 3.79
Methods 93.333% (14/15) 👍 0.985
Lines 97.749% (304/311) 👍 9.016
Conditionals 100.0% (0/0) 💚

@kgeller
Copy link
Contributor

kgeller commented Nov 9, 2023

@miguelhdezsob CI is looking good. Just a couple final comments and we should be good to go :)

@kgeller
Copy link
Contributor

kgeller commented Nov 9, 2023

/test

kgeller
kgeller approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh mentioned this pull request Nov 10, 2023
Closed
@andrewkroh andrewkroh linked an issue Nov 10, 2023 that may be closed by this pull request
[New Integration] Mandiant Threat Intelligence #8456
Closed
@kgeller kgeller merged commit ed1de83 into elastic:main Nov 14, 2023
4 checks passed
@elasticmachine
Copy link

Package ti_mandiant_advantage - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=ti_mandiant_advantage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgeller kgeller kgeller approved these changes

Assignees
No one assigned
Labels
Integration:Mandiant Advantage Threat Intel New Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Integration] Mandiant Threat Intelligence
5 participants
@miguelhdezsob @elasticmachine @kgeller @andrewkroh @jamiehynds