Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kafka] Make all the remaining SSL fields configurable via Fleet UI #8401

Merged
merged 5 commits into from Dec 6, 2023

Conversation

devamanv
Copy link
Contributor

@devamanv devamanv commented Nov 4, 2023

Proposed commit message

See title

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Run elastic-package test pipeline -v to verify that all tests pass
  • Install the Kafka integration and configure the SSL fields from the Fleet UI
  • Verify that the fields are present in the policy and their values

Related issues

Screenshots

Verified that SSL fields are present in the Agent policy and have the correct values as entered while installing the package

image

image

@devamanv devamanv added the enhancement New feature or request label Nov 4, 2023
@elasticmachine
Copy link

elasticmachine commented Nov 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-06T09:16:49.502+0000

  • Duration: 15 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 20
Skipped 0
Total 20

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 4, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 72.222% (13/18)
Lines 78.082% (57/73)
Conditionals 100.0% (0/0) 💚

@devamanv devamanv marked this pull request as ready for review December 4, 2023 05:52
@devamanv devamanv requested a review from a team as a code owner December 4, 2023 05:52
@@ -62,6 +62,15 @@ policy_templates:
- name: ssl.key
type: text
show_user: true
- name: ssl.key_passphrase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the title field here for all ssl.* fields based on the description here in configuration parameter? It doesn't look good on the UI with technical fields name, it should be moreover user friendly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good overall but ++ to this comment by Milan.

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@milan-elastic
Copy link
Contributor

Looks good!

Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: ssl.* could be provided in advance settings too right (by setting show_user: false)? If yes, not sure changing it now is a good idea or not.

I do not know the decision behind keeping show_user: true for ssl.{key,certificate,certificate_authorities}

@devamanv
Copy link
Contributor Author

devamanv commented Dec 6, 2023

LGTM

nit: ssl.* could be provided in advance settings too right (by setting show_user: false)? If yes, not sure changing it now is a good idea or not.

I do not know the decision behind keeping show_user: true for ssl.{key,certificate,certificate_authorities}

@shmsr before this change, we already had a couple of ssl fields with show_user: true, I just added the missing ones. That's why didn't change the behavior. No other reason. If you feel they should all be hidden, please let me know and. I will make the change.

@devamanv devamanv merged commit 4482c05 into elastic:main Dec 6, 2023
4 checks passed
@devamanv devamanv deleted the add-ssl-fields-kafka branch December 6, 2023 10:30
@elasticmachine
Copy link

Package kafka - 1.11.0 containing this change is available at https://epr.elastic.co/search?package=kafka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Kafka] Add YAML boxes for the missing SSL related fields
4 participants