New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kafka] Make all the remaining SSL fields configurable via Fleet UI #8401
Conversation
🌐 Coverage report
|
@@ -62,6 +62,15 @@ policy_templates: | |||
- name: ssl.key | |||
type: text | |||
show_user: true | |||
- name: ssl.key_passphrase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the title
field here for all ssl.*
fields based on the description here in configuration parameter? It doesn't look good on the UI with technical fields name, it should be moreover user friendly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good overall but ++ to this comment by Milan.
🚀 Benchmarks reportTo see the full report comment with |
Looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nit: ssl.*
could be provided in advance settings too right (by setting show_user: false
)? If yes, not sure changing it now is a good idea or not.
I do not know the decision behind keeping show_user: true
for ssl.{key,certificate,certificate_authorities}
@shmsr before this change, we already had a couple of ssl fields with |
Package kafka - 1.11.0 containing this change is available at https://epr.elastic.co/search?package=kafka |
Proposed commit message
See title
Checklist
changelog.yml
file.How to test this PR locally
elastic-package test pipeline -v
to verify that all tests passRelated issues
Screenshots
Verified that SSL fields are present in the Agent policy and have the correct values as entered while installing the package