Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o365: allow user configuration of API request batch size #8413

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 6, 2023

Proposed commit message

API responses may be very large, so allow users to specify the length of the response interval. Set the default to a reasonably short value to favour a slow flow rate over an OOM for the worse case.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

API responses may be very large, so allow users to specify the length of
the response interval. Set the default to a reasonably short value to
favour a slow flow rate over an OOM for the worse case.
@elasticmachine
Copy link

elasticmachine commented Nov 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-06T23:52:30.700+0000

  • Duration: 16 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (16/16) 💚
Lines 81.579% (744/912) 👍
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 7, 2023 00:08
@efd6 efd6 requested a review from a team as a code owner November 7, 2023 00:08
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 requested a review from kcreddy November 7, 2023 00:08
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6 efd6 merged commit 7b3d1ec into elastic:main Nov 7, 2023
4 checks passed
@elasticmachine
Copy link

Package o365 - 1.27.0 containing this change is available at https://epr.elastic.co/search?package=o365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:o365
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants