Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entityanalytics_okta: allow dataset selection #8472

Merged
merged 1 commit into from Nov 14, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 13, 2023

Proposed commit message

Test infrastructure is added for device/all datasets to be tested, but this is not enabled to allow retention of users below 8.11.

Note: running tests against v8.11 with dataset=all passes locally. When kibana.version is bumped to 8.11+ we can add the all case system test config.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Nov 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-13T09:32:27.279+0000

  • Duration: 16 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 13, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.86
Classes 100.0% (1/1) 💚 3.86
Methods 100.0% (9/9) 💚 7.804
Lines 90.675% (564/622) 👍 2.063
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 13, 2023 02:08
@efd6 efd6 requested a review from a team as a code owner November 13, 2023 02:08
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the upgrade scenario from 0.7.0 to 0.8.0 tested? Looks like a mandatory field is introduced in the new version , so just wanted to check if an upgrade on Kibana UI is seamless.

Test infrastructure is added for device/all datasets to be tested, but
this is not enabled to allow retention of users below 8.11.
@efd6 efd6 merged commit 838cd48 into elastic:main Nov 14, 2023
4 checks passed
@elasticmachine
Copy link

Package entityanalytics_okta - 0.8.0 containing this change is available at https://epr.elastic.co/search?package=entityanalytics_okta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:Okta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[entityanalytics_okta] System tests not producing expected event data in 8.11
3 participants