Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloudflare_logpush] Add support for updated security fields #8480

Merged
merged 2 commits into from Nov 14, 2023
Merged

[cloudflare_logpush] Add support for updated security fields #8480

merged 2 commits into from Nov 14, 2023

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Nov 13, 2023 •
edited

https://developers.cloudflare.com/logs/reference/change-notices/2023-02-01-security-fields-updates/#http-requests-dataset-changes

New field name Old field name
SecurityRuleID WAFRuleID
SecurityRuleDescription WAFRuleMessage
SecurityAction WAFAction
SecurityRuleIDs FirewallMatchesRuleIDs
SecurityActions FirewallMatchesActions
SecuritySources FirewallMatchesSources

Proposed commit message

  • Add support for renamed security fields in http_request data stream
  • Old fields remain for backward compatibility
  • Update test files to use new fields

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/cloudflare_logpush elastic-package test

@taylor-swanson
[cloudflare_logpush] Add support for updated security fields
a6ec315 
- Add support for renamed security fields in http_request data stream
- Old fields remain for backward compatibility
- Update test files to use new fields
@taylor-swanson taylor-swanson self-assigned this Nov 13, 2023
@elasticmachine
Copy link

elasticmachine commented Nov 13, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-13T16:25:32.427+0000

  • Duration: 28 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 115
Skipped 0
Total 115

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (18/18) 💚
Files 100.0% (18/18) 💚 4.327
Classes 100.0% (18/18) 💚 4.327
Methods 100.0% (215/215) 💚 8.792
Lines 91.723% (4898/5340) 👍 4.306
Conditionals 100.0% (0/0) 💚

@taylor-swanson taylor-swanson marked this pull request as ready for review November 13, 2023 17:20
@taylor-swanson taylor-swanson requested a review from a team as a code owner November 13, 2023 17:20
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@taylor-swanson taylor-swanson merged commit a55d675 into elastic:main Nov 14, 2023
4 checks passed
@taylor-swanson taylor-swanson deleted the bug/cloudflare-logpush-renamed-fields branch November 14, 2023 13:31
@elasticmachine
Copy link

Package cloudflare_logpush - 1.17.2 containing this change is available at https://epr.elastic.co/search?package=cloudflare_logpush

@b2ronn b2ronn mentioned this pull request Nov 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgeller kgeller kgeller approved these changes

@efd6 efd6 efd6 approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
bug Something isn't working Integration:Cloudflare Logpush Cloudflare Logpush
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taylor-swanson @elasticmachine @kgeller @efd6