Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O365 | Add permissions to docs #8494

Merged
merged 5 commits into from
Dec 5, 2023
Merged

O365 | Add permissions to docs #8494

merged 5 commits into from
Dec 5, 2023

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Nov 14, 2023

Proposed commit message

The setup and permissions required were missing and/or too vague for the users to follow. So update the integration docs to reflect O365 Management API permissions that are required to consume audit logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kcreddy kcreddy self-assigned this Nov 14, 2023
@kcreddy kcreddy added documentation Improvements or additions to documentation Integration:o365 Microsoft Office 365 labels Nov 14, 2023
@elasticmachine
Copy link

elasticmachine commented Nov 14, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-16T07:56:02.201+0000

  • Duration: 17 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 14, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (16/16) 💚 2.469
Lines 81.579% (744/912) 👎 -0.814
Conditionals 100.0% (0/0) 💚

@kcreddy kcreddy marked this pull request as ready for review November 14, 2023 11:30
@kcreddy kcreddy requested a review from a team as a code owner November 14, 2023 11:30
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
Copy link
Contributor

efd6 commented Nov 16, 2023

Suggested commit message:

The setup and permissions required were missing and/or too vague for the users
to follow. So update the integration docs to reflect O365 Management API
permissions that are required to consume audit logs.

(the WHAT and WHY were intended to be directives to the commit message author not to be included in the commit message).

Change looks good for language. Deferring to people with expertise in the configuration.

@kcreddy kcreddy merged commit 5fce152 into elastic:main Dec 5, 2023
4 checks passed
@elasticmachine
Copy link

Package o365 - 1.29.1 containing this change is available at https://epr.elastic.co/search?package=o365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Integration:o365 Microsoft Office 365
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants