New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set frozen/cold tier for Security ML integrations #8500
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started! Changes look good, but you'd have to update the package versions as well, specifically, you'd add a new entry to the changelog and bump the version in the manifest file. See this PR for reference.
Re: @ajosh0504 |
+1 to Apoorva, you'll need to bump the versions in changelog, manifest and for LMD transform fleet version as well! Otherwise, the filters are looking good. |
Comments on draft PR addressed, now changing to ready for review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for adding these extra conditions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm!
/test |
Buildkite's showing this error for DGA:
When I spin up a local stack to test, I can install DGA however: The other packages are fine as well on Buildkite. Might test again later to see if the tests can succeed. |
It looks like BuildKite is testing with a small ES node (1GB JVM heap) and there's too much going on simultaneously for that size of node. I don't think the changes in this PR caused this. |
Sounds good, won't merge today (Nov 14) end of day, but aiming for tomorrow morning (Nov 15) to try again and merge. But otherwise this should be good. |
Package ded - 2.1.1 containing this change is available at https://epr.elastic.co/search?package=ded |
Package dga - 2.0.1 containing this change is available at https://epr.elastic.co/search?package=dga |
Package lmd - 2.1.2 containing this change is available at https://epr.elastic.co/search?package=lmd |
Package problemchild - 2.1.1 containing this change is available at https://epr.elastic.co/search?package=problemchild |
Proposed commit message
Per discussion brought up by @SourinPaul , here is a draft PR illustrating what the packages would look like with the data frozen tier and data cold tier filtered out. The PR also lints/formats these files with
elastic-package
to make sure the additional field conforms to style guides.However, we must first discuss with the authors of those respective packages if that is the expected behavior before merging. @ajosh0504 @sodhikirti07 [Edit] We've discussed these changes and gotten approval.
Affected packages:
Checklist
changelog.yml
file.Additional info:
How to test this PR locally
Related issues
Screenshots