Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11Y] [AWS Redshift] Convert "AWS Redshift metrics overview" visualizations to new metric #8513

Merged
merged 5 commits into from
Nov 30, 2023
Merged

[O11Y] [AWS Redshift] Convert "AWS Redshift metrics overview" visualizations to new metric #8513

merged 5 commits into from
Nov 30, 2023

Conversation

niraj-elastic
Copy link
Contributor

@niraj-elastic niraj-elastic commented Nov 15, 2023 •
edited
Loading

What does this PR do?

Convert "AWS Redshift metrics overview" visualizations to new metric.

  • Note : Need to update the kibana version to 8.10.2 as visualizations are throwing following error in 8.9.0 and 8.9.2 which seems to be solved in 8.10.2
    1203134667-image

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels is populated with data.
  • I have updated screenshots of the dashboard.
  • I have verified that the panel aggregations are the same as before.

Related issues

Screenshots

metricbeat-aws-redshift-overview

@niraj-elastic niraj-elastic requested review from a team as code owners November 15, 2023 09:36
@elasticmachine
Copy link

elasticmachine commented Nov 15, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-24T08:14:30.904+0000

  • Duration: 89 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 223
Skipped 3
Total 226

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@harnish-elastic
Copy link
Contributor

/test

@elasticmachine
Copy link

elasticmachine commented Nov 15, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👍 72.222
Classes 94.444% (17/18) 👍 72.222
Methods 89.701% (270/301) 👍 56.368
Lines 86.083% (7571/8795) 👍 63.076
Conditionals 100.0% (0/0) 💚

@drewdaemon
Copy link
Contributor

@gvnmagni any feedback here on the use of the new metric?

@niraj-elastic
Merge branch 'main' of github.com:niraj-elastic/integrations into aws…
4fa37cf 
…-convert-redshift-visualization-to-new-metric

Conflicts:
	packages/aws/changelog.yml
@gvnmagni
Copy link

I'd suggest to activate the use of margins between panels, it would improve the visual separation between charts and probably also the metric will loo better

drewdaemon
drewdaemon approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gvnmagni . @niraj-elastic you can find this setting in dashboard settings flyout

Screen.Recording.2023-11-16.at.7.50.13.AM.mov

Approving since this PR already accomplishes the main task.

harnish-elastic
harnish-elastic approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@niraj-elastic
Copy link
Contributor Author

Thanks @gvnmagni . @niraj-elastic you can find this setting in dashboard settings flyout

Screen.Recording.2023-11-16.at.7.50.13.AM.mov
Approving since this PR already accomplishes the main task.

Updated, thanks!

@niraj-elastic
Merge branch 'main' of github.com:niraj-elastic/integrations into aws…
69f5ae1 
…-convert-redshift-visualization-to-new-metric

Conflicts:
	packages/aws/changelog.yml
	packages/aws/manifest.yml
@aliabbas-elastic
Copy link
Contributor

/test

@aliabbas-elastic aliabbas-elastic merged commit 32100cb into elastic:main Nov 30, 2023
4 checks passed
@elasticmachine
Copy link

Package aws - 2.10.0 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspacca aspacca aspacca approved these changes

@drewdaemon drewdaemon drewdaemon approved these changes

@mbondyra mbondyra mbondyra approved these changes

@harnish-elastic harnish-elastic harnish-elastic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@niraj-elastic @elasticmachine @harnish-elastic @drewdaemon @gvnmagni @aliabbas-elastic @aspacca @mbondyra