Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elasticsearch] Pipeline Convert Processor ignore_missing for elasticsearch.audit.user.run_as.name #8522

Merged
merged 3 commits into from Nov 29, 2023

Conversation

BenB196
Copy link
Contributor

@BenB196 BenB196 commented Nov 16, 2023

Proposed commit message

Fixes an issue where elasticsearch.audit.user.run_as.name being missing would cause the processor to error (though ignored).

This is an issue because in high throughput clusters, these error numbers can skew failure ratios with other processors.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Before Upgrade:

image

After Upgrade:

image

@BenB196 BenB196 requested a review from a team as a code owner November 16, 2023 00:14
@BenB196 BenB196 changed the title [Elasticsearch] Pipeline ignore_missing elasticsearch.audit.user.run_as.name [Elasticsearch] Pipeline ignore_missing for elasticsearch.audit.user.run_as.name Nov 16, 2023
@BenB196 BenB196 changed the title [Elasticsearch] Pipeline ignore_missing for elasticsearch.audit.user.run_as.name [Elasticsearch] Pipeline Convert Processor ignore_missing for elasticsearch.audit.user.run_as.name Nov 16, 2023
@elasticmachine
Copy link

elasticmachine commented Nov 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-29T03:00:57.180+0000

  • Duration: 37 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 60
Skipped 0
Total 60

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@BenB196
Copy link
Contributor Author

BenB196 commented Nov 28, 2023

@smith don't mean to bother, but I see you approved this PR, but it looks like someone needs to run the tests and then merge.

@smith
Copy link
Contributor

smith commented Nov 28, 2023

@elasticmachine test this please

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 87.5% (98/112)
Lines 91.993% (563/612)
Conditionals 100.0% (0/0) 💚

@smith smith merged commit 440fd6b into elastic:main Nov 29, 2023
3 checks passed
@elasticmachine
Copy link

Package elasticsearch - 1.11.1 containing this change is available at https://epr.elastic.co/search?package=elasticsearch

@BenB196 BenB196 deleted the elasticsearch-fix-pipeline branch November 29, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Elasticsearch] logs-elasticsearch.audit convert processor has 100% failure rate.
3 participants