Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric_type mapping for the fields of proxy dataset. #8539

Merged

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Nov 20, 2023

Proposed commit message

This PR adds the metric_type mapping for the fields of proxy datastream of Redis Enterprise.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Screenshot 2023-11-24 at 2 49 56 PM Screenshot 2023-11-24 at 2 49 29 PM

@ritalwar ritalwar added the enhancement New feature or request label Nov 20, 2023
@ritalwar ritalwar requested a review from a team as a code owner November 20, 2023 09:48
@ritalwar ritalwar mentioned this pull request Nov 20, 2023
11 tasks
@elasticmachine
Copy link

elasticmachine commented Nov 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-27T10:32:21.271+0000

  • Duration: 15 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 20, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 77.778
Classes 100.0% (0/0) 💚 77.778
Methods 50.0% (4/8) 👍 16.667
Lines 100.0% (0/0) 💚 76.993
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit c82a7cd into elastic:main Nov 27, 2023
4 checks passed
@elasticmachine
Copy link

Package redisenterprise - 0.8.3 containing this change is available at https://epr.elastic.co/search?package=redisenterprise

@andrewkroh andrewkroh added the Integration:redisenterprise Redis Enterprise label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:redisenterprise Redis Enterprise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants