Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trendmicro: add support for tls and test tcp/udp inputs #8563

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 22, 2023

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented Nov 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-24T07:06:34.642+0000

  • Duration: 17 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 22, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 22.222% (2/9) 👎 -72.222
Classes 22.222% (2/9) 👎 -72.222
Methods 33.333% (14/42) 👎 -56.368
Lines 23.007% (101/439) 👎 -63.076
Conditionals 100.0% (0/0) 💚

@efd6 efd6 marked this pull request as ready for review November 22, 2023 21:43
@efd6 efd6 requested a review from a team as a code owner November 22, 2023 21:43
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
Could add assert.hit_count to system test configurations.

@efd6 efd6 merged commit b291bbc into elastic:main Nov 24, 2023
4 checks passed
@elasticmachine
Copy link

Package trendmicro - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=trendmicro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:TrendMicro TrendMicro
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants