Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Airflow] Add system tests for the integration package #8564

Merged

Conversation

aliabbas-elastic
Copy link
Contributor

@aliabbas-elastic aliabbas-elastic commented Nov 23, 2023

Proposed commit message

  • Added system tests for Airflow integration using the observability/stream image
  • Updated the Kibana version to 8.11.0 as per comment

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  1. elastic-package check
  2. elastic-package stack up -d -v
  3. elastic-package test -v

Related issues

Screenshots

image

@aliabbas-elastic aliabbas-elastic added enhancement New feature or request Integration:airflow Airflow integration labels Nov 23, 2023
@aliabbas-elastic aliabbas-elastic self-assigned this Nov 23, 2023
@aliabbas-elastic aliabbas-elastic changed the title add system tests [O11y][Airflow] Add system tests for the integration Nov 23, 2023
@elasticmachine
Copy link

elasticmachine commented Nov 23, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-28T13:07:21.743+0000

  • Duration: 16 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 23, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 75.0% (3/4) 👎 -18.75
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@aliabbas-elastic aliabbas-elastic marked this pull request as ready for review November 23, 2023 07:20
@aliabbas-elastic aliabbas-elastic requested a review from a team as a code owner November 23, 2023 07:20
@ritalwar ritalwar self-requested a review November 24, 2023 06:35
@harnish-elastic harnish-elastic changed the title [O11y][Airflow] Add system tests for the integration [O11y][Airflow] Add system tests for the integration package Nov 24, 2023
@ritalwar
Copy link
Contributor

ritalwar commented Nov 28, 2023

I suggest upgrading the Kibana version to 8.11 to align with the modifications in the statsd module implementation in Beats, which are available in version 8.11. Subsequently, we should execute the tests based on the correct implementation.
@lalit-satapathy @SubhrataK

@aliabbas-elastic
Copy link
Contributor Author

I suggest upgrading the Kibana version to 8.11 to align with the modifications in the statsd module implementation in elastic/beats#36925, which are available in version 8.11. Subsequently, we should execute the tests based on the correct implementation.

Sure Let me update it accordingly

packages/airflow/changelog.yml Outdated Show resolved Hide resolved
packages/airflow/changelog.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aliabbas-elastic aliabbas-elastic merged commit 00232ea into elastic:main Nov 28, 2023
4 checks passed
@elasticmachine
Copy link

Package airflow - 0.6.0 containing this change is available at https://epr.elastic.co/search?package=airflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:airflow Airflow integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Airflow] create system test cases for the statsD data stream
4 participants