Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloud_security_posture] Support Azure account type #8581

Merged
merged 6 commits into from
Nov 29, 2023
Merged

[cloud_security_posture] Support Azure account type #8581

merged 6 commits into from
Nov 29, 2023

Conversation

jeniawhite
Copy link
Contributor

@jeniawhite jeniawhite commented Nov 27, 2023 •
edited
Loading

Proposed commit message

Support Azure account type for organizations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Check if we should have separate templates for organization and single account flows

Related issues

@jeniawhite jeniawhite added the enhancement New feature or request label Nov 27, 2023
@jeniawhite jeniawhite requested a review from a team as a code owner November 27, 2023 17:04
@elasticmachine
Copy link

elasticmachine commented Nov 27, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-28T15:38:12.596+0000

  • Duration: 16 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 27, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) 👎 -75.0
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

orestisfl
orestisfl approved these changes Nov 28, 2023
View reviewed changes
packages/cloud_security_posture/changelog.yml Outdated
changes:
- description: Add Azure account type support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- description: Add Azure account type support
- description: Support Azure Management groups

packages/cloud_security_posture/manifest.yml Outdated
@@ -140,6 +140,7 @@ policy_templates:
required: true
show_user: false
description: A URL to the ARM Template for creating a new deployment
# TODO: Should we have seperate templates for organization and single account? Or deploy the same template for both with discovery?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be separate, I'll update the url once the ARM template is finished

@jeniawhite jeniawhite mentioned this pull request Nov 28, 2023
Merged
5 tasks
orestisfl
orestisfl requested changes Nov 28, 2023
View reviewed changes
packages/cloud_security_posture/manifest.yml Outdated
@@ -140,7 +140,8 @@ policy_templates:
required: true
show_user: false
description: A URL to the ARM Template for creating a new deployment
default: https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2Felastic%2Fcloudbeat%2F8.11%2Fdeploy%2Fazure%2FazureARMTemplate.json
# ACCOUNT_TYPE value should be either "single-account" or "organization-account"
default: https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2Felastic%2Fcloudbeat%2F8.11%2Fdeploy%2Fazure%2FazureARMTemplate-ACCOUNT_TYPE.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
default: https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2Felastic%2Fcloudbeat%2F8.11%2Fdeploy%2Fazure%2FazureARMTemplate-ACCOUNT_TYPE.json
default: https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2Felastic%2Fcloudbeat%2F8.12%2Fdeploy%2Fazure%2FARM-for-ACCOUNT_TYPE.json

@orestisfl
Copy link
Contributor

I suggest merging after elastic/cloudbeat#1601 to double check the link works first

@jeniawhite jeniawhite merged commit ffc16ef into elastic:main Nov 29, 2023
4 checks passed
@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview05 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview06 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview07 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview08 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0-preview09 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@elasticmachine
Copy link

Package cloud_security_posture - 1.7.0 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orestisfl orestisfl orestisfl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CIS Azure] Account type support in the HBS
3 participants
@jeniawhite @elasticmachine @orestisfl