[apache_tomcat.access] Restructure Grok pattern and ingest pipeline to improve performance #8615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
/test |
ishleenk17
reviewed
Nov 30, 2023
shmsr
requested changes
Nov 30, 2023
packages/apache_tomcat/data_stream/access/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
packages/apache_tomcat/data_stream/access/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
shmsr
changed the title
shmsr
reviewed
Nov 30, 2023
packages/apache_tomcat/data_stream/access/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
shmsr
reviewed
Nov 30, 2023
packages/apache_tomcat/data_stream/access/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
shmsr
changed the title
shmsr
changed the title
Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
SimonKoetting
commented
Nov 30, 2023
shmsr
approved these changes
Dec 1, 2023
|
Package apache_tomcat - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=apache_tomcat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The customer is using this Integration on an ESS and had ~10-14ms per doc average processing Time.
After taking a look at the pipeline definition I recognised the "inefficient" way how the grok processing is done.
First test of restructuring the grok process (without changing what it is doing, just how it is done) I had an average of 0-5-0.-7ms, so a huge performance improvement with just a little restructuring.