Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IIS Access Log]: Update documentation for custom log processing #8659

Merged
merged 6 commits into from
Dec 6, 2023

Conversation

muthu-mps
Copy link
Contributor

@muthu-mps muthu-mps commented Dec 6, 2023

  • Enhancement

Proposed commit message

Add note on the custom access log format processing.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Author's Checklist

  • [ ]

Related issues

@muthu-mps muthu-mps self-assigned this Dec 6, 2023
@elasticmachine
Copy link

elasticmachine commented Dec 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-06T11:34:23.653+0000

  • Duration: 15 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Dec 6, 2023

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Dec 6, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 86.111% (31/36) 👍 13.889
Lines 96.143% (349/363) 👍 18.061
Conditionals 100.0% (0/0) 💚

@muthu-mps muthu-mps marked this pull request as ready for review December 6, 2023 09:02
@muthu-mps muthu-mps requested a review from a team as a code owner December 6, 2023 09:02
Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@devamanv devamanv added the enhancement New feature or request label Dec 6, 2023
muthu-mps and others added 2 commits December 6, 2023 16:28
Co-authored-by: Aman <38116245+devamanv@users.noreply.github.com>
Co-authored-by: Aman <38116245+devamanv@users.noreply.github.com>
@devamanv
Copy link
Contributor

devamanv commented Dec 6, 2023

Also it's good to add a small description for the Proposed commit message or just use "see title" if the title is enough. We should start following the template which says:

This text will be pasted into the squash dialog when the change is committed and will be a long term historical record of the change to help future contributors understand the change, please help them by making it clear and comprehensive, they may be you.

Copy link
Contributor

@devamanv devamanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/iis/docs/README.md Outdated Show resolved Hide resolved
packages/iis/docs/README.md Outdated Show resolved Hide resolved
packages/iis/docs/README.md Outdated Show resolved Hide resolved
@muthu-mps muthu-mps requested a review from shmsr December 6, 2023 11:31
packages/iis/changelog.yml Outdated Show resolved Hide resolved
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment. Otherwise, LGTM.

@shmsr shmsr changed the title [IIS Access Log] - Update document for custom log processing [IIS Access Log]: Update documentation for custom log processing Dec 6, 2023
@muthu-mps muthu-mps merged commit 8f35423 into elastic:main Dec 6, 2023
4 checks passed
@elasticmachine
Copy link

Package iis - 1.17.3 containing this change is available at https://epr.elastic.co/search?package=iis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IIS] Enhance the document on support for default & custom log formats
5 participants