Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Logs - Extend storage account settings #8666

Merged
merged 3 commits into from Dec 12, 2023

Conversation

alaudazzi
Copy link
Contributor

On the Azure Logs integration doc page, this PR:

  • Updates the storage account requirements
  • Simplifies the setup procedure

This doc fix impacts the following Azure doc pages as well:
├── activitylogs
├── application_gateway
├── auditlogs
├── eventhub
├── firewall_logs
├── identity_protection
├── platformlogs
├── provisioning
├── signinlogs
└── springcloudlogs

Closes #7586

Doc preview:
image

@alaudazzi alaudazzi added the enhancement New feature or request label Dec 7, 2023
@alaudazzi alaudazzi requested a review from a team as a code owner December 7, 2023 13:03
@elasticmachine
Copy link

elasticmachine commented Dec 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-07T16:48:16.715+0000

  • Duration: 15 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 83
Skipped 0
Total 83

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🚀 Benchmarks report

Package azure 👍(5) 💚(1) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
springcloudlogs 4975.12 3921.57 -1053.55 (-21.18%) 💔
activitylogs 1404.49 1078.75 -325.74 (-23.19%) 💔
application_gateway 1672.24 1308.9 -363.34 (-21.73%) 💔
eventhub 500000 333333.33 -166666.67 (-33.33%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 86.364% (19/22)
Classes 86.364% (19/22)
Methods 83.333% (155/186)
Lines 85.021% (2821/3318)
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alaudazzi alaudazzi merged commit 33dacbc into elastic:main Dec 12, 2023
4 checks passed
@elasticmachine
Copy link

Package azure - 1.8.2 containing this change is available at https://epr.elastic.co/search?package=azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Azure] [Docs] extend the storage account requirements in the Azure Logs documentation
3 participants