Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure metrics - Expand OS guest metrics section #8673

Merged
merged 3 commits into from Dec 12, 2023
Merged

Azure metrics - Expand OS guest metrics section #8673

merged 3 commits into from Dec 12, 2023

Conversation

alaudazzi
Copy link
Contributor

@alaudazzi alaudazzi commented Dec 7, 2023 •
edited

On the Azure Virtual Machines Metrics this PR:

  • adds clear instructions on how to set up OS guest metrics
  • provides meaningful links to additional MS resources

Closes #7181

Doc preview:

image

@alaudazzi alaudazzi added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 7, 2023
@alaudazzi alaudazzi requested a review from zmoog December 7, 2023 17:41
@alaudazzi alaudazzi requested a review from a team as a code owner December 7, 2023 17:41
@alaudazzi alaudazzi changed the title Azure metrics - Expand guest metrics section Azure metrics - Expand OS guest metrics section Dec 7, 2023
@elasticmachine
Copy link

elasticmachine commented Dec 7, 2023 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-12T10:00:08.994+0000

  • Duration: 17 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 34
Skipped 0
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Dec 7, 2023 •
edited

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Dec 7, 2023 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 5.556
Classes 100.0% (4/4) 💚 5.556
Methods 75.758% (25/33) 👎 -19.211
Lines 100.0% (32/32) 💚 12.295
Conditionals 100.0% (0/0) 💚

zmoog
zmoog approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alaudazzi alaudazzi merged commit 906fa8b into elastic:main Dec 12, 2023
4 checks passed
@elasticmachine
Copy link

Package azure_metrics - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Azure] [Docs] Expand Azure VM Guest Metrics documentation
3 participants
@alaudazzi @elasticmachine @zmoog