Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] Remove disabled fields #8679

Merged
merged 2 commits into from Dec 11, 2023
Merged

[Cloud Security] Remove disabled fields #8679

merged 2 commits into from Dec 11, 2023

Conversation

opauloh
Copy link
Contributor

@opauloh opauloh commented Dec 8, 2023 •
edited

Proposed commit message

Remove fields that had enabled: false, to prevent mapping issues

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Follow the guide to test it locally.

Related issues

Screenshots

@opauloh opauloh changed the title Csp/drop disabled fields [Cloud Security] Remove disabled fields Dec 8, 2023
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-08T01:58:08.571+0000

  • Duration: 16 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (2/8) ❕
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@opauloh opauloh added the Team:Cloud Security Label for the Cloud Security team label Dec 9, 2023
@opauloh opauloh marked this pull request as ready for review December 9, 2023 03:09
@opauloh opauloh requested a review from a team as a code owner December 9, 2023 03:09
kfirpeled
kfirpeled approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@kfirpeled kfirpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kfirpeled kfirpeled merged commit e86b8ee into main Dec 11, 2023
4 checks passed
@kfirpeled kfirpeled deleted the csp/drop-disabled-fields branch December 11, 2023 08:17
@elasticmachine
Copy link

Package cloud_security_posture - 1.7.1 containing this change is available at https://epr.elastic.co/search?package=cloud_security_posture

@CohenIdo CohenIdo mentioned this pull request Jan 2, 2024
Merged
@maxcold maxcold mentioned this pull request Jan 2, 2024
Closed
4 tasks
@maxcold maxcold mentioned this pull request Jan 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfirpeled kfirpeled kfirpeled approved these changes

Assignees
No one assigned
Labels
Team:Cloud Security Label for the Cloud Security team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@opauloh @elasticmachine @kfirpeled