Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disk io metrics to fields.yml #8682

Merged
merged 5 commits into from Dec 14, 2023

Conversation

fearful-symmetry
Copy link
Contributor

Proposed commit message

Adds disk IO metrics to fields.yml, as these fields are now in metricbeat.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@fearful-symmetry fearful-symmetry added the enhancement New feature or request label Dec 8, 2023
@fearful-symmetry fearful-symmetry self-assigned this Dec 8, 2023
@fearful-symmetry fearful-symmetry requested review from a team as code owners December 8, 2023 22:09
@elasticmachine
Copy link

elasticmachine commented Dec 8, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-13T17:56:11.572+0000

  • Duration: 18 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 158
Skipped 0
Total 158

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to consider adding additional dashboard panels to display process disk IO stats?

@agithomas
Copy link
Contributor

Since system/process is TSDB enabled datastream, it is recommended to run the TSDB test tool kit to validate any possible data loss due to non-unique dimension fields.

@fearful-symmetry
Copy link
Contributor Author

@agithomas alright, tested with the toolkit, no issues.

@elasticmachine
Copy link

elasticmachine commented Dec 11, 2023

🚀 Benchmarks report

Package system 👍(1) 💚(0) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
auth 2898.55 2331 -567.55 (-19.58%) 💔
syslog 21276.6 12820.51 -8456.09 (-39.74%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Dec 11, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 67.857% (57/84)
Lines 98.426% (3002/3050)
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fearful-symmetry fearful-symmetry merged commit 6c6c3a3 into elastic:main Dec 14, 2023
4 checks passed
@elasticmachine
Copy link

Package system - 1.51.0 containing this change is available at https://epr.elastic.co/search?package=system

@IanLee1521
Copy link

Do you want to consider adding additional dashboard panels to display process disk IO stats?

Personally I do think these would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants