Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AWS]: Improve wording on milliseconds #8703

Merged
merged 4 commits into from Jan 10, 2024

Conversation

alaudazzi
Copy link
Contributor

This PR proposes a better wording for the fields total_time and turn_around_time.
Relates #123

@alaudazzi alaudazzi added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 12, 2023
@alaudazzi alaudazzi requested a review from shmsr December 12, 2023 12:51
@alaudazzi alaudazzi self-assigned this Dec 12, 2023
@alaudazzi alaudazzi requested a review from a team as a code owner December 12, 2023 12:51
@alaudazzi alaudazzi requested a review from a team as a code owner December 12, 2023 12:55
@shmsr shmsr changed the title AWS - fix wording on milliseconds [AWS]: fix wording on milliseconds Dec 12, 2023
packages/aws/changelog.yml Outdated Show resolved Hide resolved
@shmsr shmsr changed the title [AWS]: fix wording on milliseconds [AWS]: Improve wording on milliseconds Dec 12, 2023
@elasticmachine
Copy link

elasticmachine commented Dec 12, 2023

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-12T17:15:50.138+0000

  • Duration: 80 min 40 sec

Steps errors 3

Expand to view the steps failures

Test integration: aws
  • Took 65 min 3 sec . View more details here
  • Description: eval "$(../../build/elastic-package stack shellinit)" ../../build/elastic-package test -v --report-format xUnit --report-output file --test-coverage
Google Storage Download
  • Took 0 min 0 sec . View more details here
Google Storage Download
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18)
Classes 94.444% (17/18)
Methods 96.935% (253/261)
Lines 86.083% (7571/8795)
Conditionals 100.0% (0/0) 💚

Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
@shmsr
Copy link
Member

shmsr commented Dec 13, 2023

I believe we need to hold this PR, even though the changes in this PR are unrelated.

Tests that are failing for a guardduty datastream and require thorough debugging.

Error:
2023/12/13 02:04:07 DEBUG found 0 hits in logs-aws.guardduty-ep data stream: index_not_found_exception: no such index [logs-aws.guardduty-ep] Status=40

Reproduce with:
$ elastic-package test system -d guardduty -v

Couldn't figure out what the issue could be from Elasticsearch / Kibana logs. Have to spend some more time on this. I have tested with the 8.9.0 and 8.10.2 stack, but couldn't make the tests pass.

@mrodm
Copy link
Contributor

mrodm commented Dec 21, 2023

Hi @alaudazzi, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks!

@alaudazzi alaudazzi requested review from a team as code owners January 10, 2024 12:37
@elasticmachine
Copy link

🚀 Benchmarks report

Package aws 👍(7) 💚(7) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
ec2_logs 45454.55 30303.03 -15151.52 (-33.33%) 💔
elb_logs 6250 3846.15 -2403.85 (-38.46%) 💔
emr_logs 32258.06 23809.52 -8448.54 (-26.19%) 💔

To see the full report comment with /test benchmark fullreport

@alaudazzi alaudazzi merged commit 5698821 into elastic:main Jan 10, 2024
3 checks passed
@elasticmachine
Copy link

Package aws - 2.11.1 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants