Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MongoDB]: Improve wording on milliseconds #8704

Merged
merged 3 commits into from Dec 12, 2023

Conversation

alaudazzi
Copy link
Contributor

This PR proposes a better wording for the field total.ms.
Relates #123

@alaudazzi alaudazzi added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 12, 2023
@alaudazzi alaudazzi requested a review from shmsr December 12, 2023 13:03
@alaudazzi alaudazzi self-assigned this Dec 12, 2023
@alaudazzi alaudazzi requested a review from a team as a code owner December 12, 2023 13:03
@elasticmachine
Copy link

elasticmachine commented Dec 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-12T17:16:25.287+0000

  • Duration: 20 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Dec 12, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 96.97% (32/33) 👎 -3.03
Lines 68.702% (90/131) 👎 -23.021
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@shmsr shmsr changed the title MongoDB - Fix wording on milliseconds [MongoDB]: Fix wording on milliseconds Dec 12, 2023
@shmsr shmsr changed the title [MongoDB]: Fix wording on milliseconds [MongoDB]: Improve wording on milliseconds Dec 12, 2023
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
@alaudazzi alaudazzi merged commit 70d4f7a into elastic:main Dec 12, 2023
4 checks passed
@elasticmachine
Copy link

Package mongodb - 1.12.2 containing this change is available at https://epr.elastic.co/search?package=mongodb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants