Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cisco IOS] Add support for BADAUTH events #8740

Merged
merged 3 commits into from Dec 19, 2023

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Dec 16, 2023

Proposed commit message

Currently when event.code == BADAUTH, the messages are not fully parsed leading to no source or destination mappings. Adds support for parsing these events fully.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

$ elastic-package stack down && elastic-package build && elastic-package stack up --version=8.11.0 -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test pipeline --generate -v

Run pipeline tests for the package
--- Test results for package: cisco_ios - START ---
╭───────────┬─────────────┬───────────┬───────────────────────────────┬────────┬──────────────╮
│ PACKAGE   │ DATA STREAM │ TEST TYPE │ TEST NAME                     │ RESULT │ TIME ELAPSED │
├───────────┼─────────────┼───────────┼───────────────────────────────┼────────┼──────────────┤
│ cisco_ios │ log         │ pipeline  │ test-asr920.log               │ PASS   │   2.621583ms │
│ cisco_ios │ log         │ pipeline  │ test-badauth.log              │ PASS   │   2.423667ms │
│ cisco_ios │ log         │ pipeline  │ test-cisco-ios.log            │ PASS   │   5.215458ms │
│ cisco_ios │ log         │ pipeline  │ test-date-format-tzoffset.log │ PASS   │   2.742417ms │
│ cisco_ios │ log         │ pipeline  │ test-date-format.log          │ PASS   │   3.240875ms │
│ cisco_ios │ log         │ pipeline  │ test-syslog-header.log        │ PASS   │   4.122792ms │
│ cisco_ios │ log         │ pipeline  │ test-syslog.log               │ PASS   │   5.517542ms │
╰───────────┴─────────────┴───────────┴───────────────────────────────┴────────┴──────────────╯
--- Test results for package: cisco_ios - END   ---
Done

Related issues

Screenshots

@kcreddy kcreddy added enhancement New feature or request Integration:CiscoIOS Cisco IOS labels Dec 16, 2023
@kcreddy kcreddy self-assigned this Dec 16, 2023
@kcreddy kcreddy marked this pull request as ready for review December 16, 2023 09:24
@kcreddy kcreddy requested a review from a team as a code owner December 16, 2023 09:24
@elasticmachine
Copy link

🚀 Benchmarks report

Package cisco_ios 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 2849 682.13 -2166.87 (-76.06%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Dec 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-18T14:18:14.115+0000

  • Duration: 38 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 14
Skipped 0
Total 14

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Dec 16, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 5.556
Classes 100.0% (1/1) 💚 5.556
Methods 100.0% (15/15) 💚 22.597
Lines 92.365% (375/406) 👍 6.282
Conditionals 100.0% (0/0) 💚

@kcreddy kcreddy requested a review from efd6 December 18, 2023 14:18
@kcreddy kcreddy merged commit 1998034 into elastic:main Dec 19, 2023
4 checks passed
@elasticmachine
Copy link

Package cisco_ios - 1.24.0 containing this change is available at https://epr.elastic.co/search?package=cisco_ios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:CiscoIOS Cisco IOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants